Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix yml test {p0=indices.delete_index_template/10_basic} is flaky #15162

Merged
merged 2 commits into from
Aug 8, 2024

Conversation

gaobinlong
Copy link
Collaborator

@gaobinlong gaobinlong commented Aug 8, 2024

Description

org.opensearch.backwards.MixedClusterClientYamlTestSuiteIT.test {p0=indices.delete_index_template/10_basic/Delete index template which is not used by data stream but index pattern matches} is flaky, the reason is that the mixed version cluster has a template with index patterns *, so when creating a new index template, the API returns a warning header index template [test_template_1] has index patterns [test-*]....

Related Issues

Resolves #15161

Check List

- [ ] Functionality includes testing.
- [ ] API changes companion pull request created, if applicable.
- [ ] Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Gao Binlong <gbinlong@amazon.com>
@github-actions github-actions bot added bug Something isn't working flaky-test Random test failure that succeeds on second run labels Aug 8, 2024
@gaobinlong gaobinlong added backport 2.x Backport to 2.x branch and removed bug Something isn't working flaky-test Random test failure that succeeds on second run labels Aug 8, 2024
@github-actions github-actions bot added bug Something isn't working flaky-test Random test failure that succeeds on second run labels Aug 8, 2024
Signed-off-by: Gao Binlong <gbinlong@amazon.com>
Copy link
Contributor

github-actions bot commented Aug 8, 2024

✅ Gradle check result for 0f566dd: SUCCESS

Copy link

codecov bot commented Aug 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.75%. Comparing base (97c1bf0) to head (0f566dd).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main   #15162   +/-   ##
=========================================
  Coverage     71.74%   71.75%           
+ Complexity    62904    62848   -56     
=========================================
  Files          5178     5178           
  Lines        295167   295167           
  Branches      42679    42679           
=========================================
+ Hits         211774   211796   +22     
+ Misses        66011    65947   -64     
- Partials      17382    17424   +42     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Aug 8, 2024

❌ Gradle check result for 7c1efb1: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@reta reta merged commit 4fe0358 into opensearch-project:main Aug 8, 2024
34 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 8, 2024
…5162)

* Fix yml test {p0=indices.delete_index_template/10_basic} is flaky

Signed-off-by: Gao Binlong <gbinlong@amazon.com>

* Fix warning message

Signed-off-by: Gao Binlong <gbinlong@amazon.com>

---------

Signed-off-by: Gao Binlong <gbinlong@amazon.com>
(cherry picked from commit 4fe0358)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
reta pushed a commit that referenced this pull request Aug 8, 2024
…5162) (#15171)

* Fix yml test {p0=indices.delete_index_template/10_basic} is flaky



* Fix warning message



---------


(cherry picked from commit 4fe0358)

Signed-off-by: Gao Binlong <gbinlong@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
harshavamsi pushed a commit to harshavamsi/OpenSearch that referenced this pull request Aug 20, 2024
…ensearch-project#15162)

* Fix yml test {p0=indices.delete_index_template/10_basic} is flaky

Signed-off-by: Gao Binlong <gbinlong@amazon.com>

* Fix warning message

Signed-off-by: Gao Binlong <gbinlong@amazon.com>

---------

Signed-off-by: Gao Binlong <gbinlong@amazon.com>
wdongyu pushed a commit to wdongyu/OpenSearch that referenced this pull request Aug 22, 2024
…ensearch-project#15162)

* Fix yml test {p0=indices.delete_index_template/10_basic} is flaky

Signed-off-by: Gao Binlong <gbinlong@amazon.com>

* Fix warning message

Signed-off-by: Gao Binlong <gbinlong@amazon.com>

---------

Signed-off-by: Gao Binlong <gbinlong@amazon.com>
akolarkunnu pushed a commit to akolarkunnu/OpenSearch that referenced this pull request Sep 10, 2024
…ensearch-project#15162)

* Fix yml test {p0=indices.delete_index_template/10_basic} is flaky

Signed-off-by: Gao Binlong <gbinlong@amazon.com>

* Fix warning message

Signed-off-by: Gao Binlong <gbinlong@amazon.com>

---------

Signed-off-by: Gao Binlong <gbinlong@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch bug Something isn't working flaky-test Random test failure that succeeds on second run skip-changelog
Projects
None yet
2 participants