Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.x] Support Filtering on Large List encoded by Bitmap #15079

Conversation

bowenlan-amzn
Copy link
Member

Description

[Describe what this change achieves]

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>
Copy link
Contributor

github-actions bot commented Aug 2, 2024

❌ Gradle check result for 3b0035b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Aug 2, 2024

❕ Gradle check result for 3b0035b: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Aug 2, 2024

Codecov Report

Attention: Patch coverage is 56.34921% with 55 lines in your changes missing coverage. Please review.

Project coverage is 71.59%. Comparing base (cc86e27) to head (3b0035b).
Report is 2 commits behind head on 2.x.

Files Patch % Lines
.../opensearch/search/query/BitmapDocValuesQuery.java 13.88% 29 Missing and 2 partials ⚠️
.../org/opensearch/index/query/TermsQueryBuilder.java 76.78% 2 Missing and 11 partials ⚠️
...org/opensearch/index/mapper/NumberFieldMapper.java 66.66% 6 Missing and 1 partial ⚠️
.../main/java/org/opensearch/indices/TermsLookup.java 69.23% 0 Missing and 4 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #15079      +/-   ##
============================================
- Coverage     71.60%   71.59%   -0.02%     
+ Complexity    62829    62772      -57     
============================================
  Files          5125     5126       +1     
  Lines        294568   294685     +117     
  Branches      42928    42955      +27     
============================================
+ Hits         210925   210976      +51     
+ Misses        66008    65965      -43     
- Partials      17635    17744     +109     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant