[Backport 2.x] [Derived Fields] Add aggregation support for derived fields #15009
Conversation
![opensearch-trigger-bot[bot]](https://github.com/avatars/u/80134844?s=60&v=4){kind=small}
* Add aggregation support for derived fields Signed-off-by: Marc Handalian <marc.handalian@gmail.com> * add unit test for a terms agg with derived fields Signed-off-by: Marc Handalian <marc.handalian@gmail.com> * Fix license header and add changelog entry Signed-off-by: Marc Handalian <marc.handalian@gmail.com> * move matrix_stats tests to aggs-matrix-stats module Signed-off-by: Marc Handalian <marc.handalian@gmail.com> * Move matrix tests back and add dependency to painless module Signed-off-by: Marc Handalian <marc.handalian@gmail.com> * add tests for all aggregations types and support ip_range Signed-off-by: Marc Handalian <marc.handalian@gmail.com> * Add tests for agg script returned from DerivedFieldType Signed-off-by: Marc Handalian <marc.handalian@gmail.com> * remove children aggs test as its not yet supported Signed-off-by: Marc Handalian <marc.handalian@gmail.com> * Add more tests Signed-off-by: Marc Handalian <marc.handalian@gmail.com> * fix changelog Signed-off-by: Marc Handalian <marc.handalian@gmail.com> --------- Signed-off-by: Marc Handalian <marc.handalian@gmail.com> (cherry picked from commit e26608b) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
gbbafna,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
|
❌ Gradle check result for 1e69ade: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
This backport is failing because the version of |
These tests fail to backport to 2.x becuase 2.x uses a different branch of tdigest that computes percentiles differently. Rather than chase these over time, change the assertions to check for the length of results returned instead of their values. Signed-off-by: Marc Handalian <marc.handalian@gmail.com> (cherry picked from commit 0cde7ba) Signed-off-by: Marc Handalian <marc.handalian@gmail.com>
|
cherry picked #15015 on top of this pr to fix the percentile ranks difference on 2.x |
|
❌ Gradle check result for 23f7128: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 23f7128: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #15009 +/- ##
============================================
+ Coverage 71.48% 71.55% +0.06%
- Complexity 62677 62751 +74
============================================
Files 5123 5123
Lines 294480 294510 +30
Branches 42912 42915 +3
============================================
+ Hits 210518 210733 +215
+ Misses 66286 66095 -191
- Partials 17676 17682 +6 ☔ View full report in Codecov by Sentry. |
Backport e26608b from #14618.