Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing value of FieldSort for unsigned_long #14963

Merged
merged 3 commits into from
Jul 30, 2024

Conversation

bugmakerrrrrr
Copy link
Contributor

Description

Two changes here:

  1. Fixes parsing numeric missing value of unsigned long type. When we pass a numeric missing value like 4 to unsigned long field sort, the ClassCastException will be thrown(class java.lang.Integer cannot be cast to class java.math.BigInteger ).
  2. Requires the missing value of unsigned long type must not be negative.

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

❌ Gradle check result for a921fb8: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 6777ca6: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for e33606f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@reta
Copy link
Collaborator

reta commented Jul 29, 2024

@bugmakerrrrrr could you please resolve the conflicts? thank you

@reta reta self-requested a review July 29, 2024 13:30
@reta reta added bug Something isn't working v3.0.0 Issues and PRs related to version 3.0.0 v2.17.0 labels Jul 29, 2024
@bugmakerrrrrr
Copy link
Contributor Author

@bugmakerrrrrr could you please resolve the conflicts? thank you

Done

Copy link
Contributor

❕ Gradle check result for f5544fb: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Jul 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 71.79%. Comparing base (0cde7ba) to head (896e850).

Files Patch % Lines
...comparator/UnsignedLongValuesComparatorSource.java 0.00% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #14963      +/-   ##
============================================
- Coverage     71.79%   71.79%   -0.01%     
+ Complexity    62736    62725      -11     
============================================
  Files          5161     5161              
  Lines        294368   294371       +3     
  Branches      42577    42578       +1     
============================================
- Hits         211337   211330       -7     
- Misses        65626    65691      +65     
+ Partials      17405    17350      -55     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reta reta added the backport 2.x Backport to 2.x branch label Jul 29, 2024
@reta
Copy link
Collaborator

reta commented Jul 29, 2024

@bugmakerrrrrr DCO check is failing sadly :(

Signed-off-by: panguixin <panguixin@bytedance.com>
Signed-off-by: panguixin <panguixin@bytedance.com>
Signed-off-by: panguixin <panguixin@bytedance.com>
Copy link
Contributor

✅ Gradle check result for 896e850: SUCCESS

@reta reta merged commit ffa67f9 into opensearch-project:main Jul 30, 2024
30 of 31 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 30, 2024
* Fix missing value of FieldSort for unsigned_long

Signed-off-by: panguixin <panguixin@bytedance.com>

* add changelog

Signed-off-by: panguixin <panguixin@bytedance.com>

* apply review comments

Signed-off-by: panguixin <panguixin@bytedance.com>

---------

Signed-off-by: panguixin <panguixin@bytedance.com>
(cherry picked from commit ffa67f9)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
reta pushed a commit that referenced this pull request Jul 30, 2024
* Fix missing value of FieldSort for unsigned_long



* add changelog



* apply review comments



---------


(cherry picked from commit ffa67f9)

Signed-off-by: panguixin <panguixin@bytedance.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
harshavamsi pushed a commit to harshavamsi/OpenSearch that referenced this pull request Aug 20, 2024
…14963)

* Fix missing value of FieldSort for unsigned_long

Signed-off-by: panguixin <panguixin@bytedance.com>

* add changelog

Signed-off-by: panguixin <panguixin@bytedance.com>

* apply review comments

Signed-off-by: panguixin <panguixin@bytedance.com>

---------

Signed-off-by: panguixin <panguixin@bytedance.com>
wdongyu pushed a commit to wdongyu/OpenSearch that referenced this pull request Aug 22, 2024
…14963)

* Fix missing value of FieldSort for unsigned_long

Signed-off-by: panguixin <panguixin@bytedance.com>

* add changelog

Signed-off-by: panguixin <panguixin@bytedance.com>

* apply review comments

Signed-off-by: panguixin <panguixin@bytedance.com>

---------

Signed-off-by: panguixin <panguixin@bytedance.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch bug Something isn't working v2.17.0 v3.0.0 Issues and PRs related to version 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants