Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Add SplitResponseProcessor to Search Pipelines #14863

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 45c5f8d from #14800.

* Add SplitResponseProcessor for search pipelines

Signed-off-by: Daniel Widdis <widdis@gmail.com>

* Register the split processor factory

Signed-off-by: Daniel Widdis <widdis@gmail.com>

* Address code review comments

Signed-off-by: Daniel Widdis <widdis@gmail.com>

* Avoid list copy by casting array

Signed-off-by: Daniel Widdis <widdis@gmail.com>

---------

Signed-off-by: Daniel Widdis <widdis@gmail.com>
(cherry picked from commit 45c5f8d)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

❕ Gradle check result for 081b705: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.action.admin.cluster.node.tasks.ResourceAwareTasksTests.testTaskResourceTrackingDuringTaskCancellation

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Jul 22, 2024

Codecov Report

Attention: Patch coverage is 92.85714% with 3 lines in your changes missing coverage. Please review.

Project coverage is 71.51%. Comparing base (feaa115) to head (081b705).
Report is 1 commits behind head on 2.x.

Files Patch % Lines
...search/pipeline/common/SplitResponseProcessor.java 92.85% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #14863      +/-   ##
============================================
+ Coverage     71.45%   71.51%   +0.06%     
- Complexity    62465    62512      +47     
============================================
  Files          5107     5108       +1     
  Lines        293633   293675      +42     
  Branches      42779    42789      +10     
============================================
+ Hits         209821   210031     +210     
+ Misses        66198    66003     -195     
- Partials      17614    17641      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbwiddis dbwiddis merged commit 3b0ea65 into 2.x Jul 22, 2024
56 checks passed
@dbwiddis dbwiddis deleted the backport/backport-14800-to-2.x branch July 22, 2024 18:58
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 22, 2024
* Add SplitResponseProcessor for search pipelines

* Register the split processor factory

* Address code review comments

* Avoid list copy by casting array

---------

(cherry picked from commit 45c5f8d)

Signed-off-by: Daniel Widdis <widdis@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 3b0ea65)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dbwiddis pushed a commit that referenced this pull request Jul 22, 2024
)

* Add SplitResponseProcessor for search pipelines

* Register the split processor factory

* Address code review comments

* Avoid list copy by casting array

---------

(cherry picked from commit 45c5f8d)




(cherry picked from commit 3b0ea65)

Signed-off-by: Daniel Widdis <widdis@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@dblock dblock added the v2.16.0 Issues and PRs related to version 2.16.0 label Jul 23, 2024
kkewwei pushed a commit to kkewwei/OpenSearch that referenced this pull request Jul 24, 2024
) (opensearch-project#14863)

* Add SplitResponseProcessor for search pipelines

* Register the split processor factory

* Address code review comments

* Avoid list copy by casting array

---------

(cherry picked from commit 45c5f8d)

Signed-off-by: Daniel Widdis <widdis@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: kkewwei <kkewwei@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.16 v2.16.0 Issues and PRs related to version 2.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants