[Backport] [1.x] Fix: update help output for _cat (#14722) #14727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reta
requested review from
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
gbbafna,
kotwanikunal,
mch2,
nknize,
owaiskazi19,
Rishikesh1159,
saratvemulapalli,
shwetathareja,
dreamer-89,
tlfeng and
VachaShah
as code owners
* fixed help output for _cat Signed-off-by: ahmedsobeh <ahmed.sobeh@aiven.io> * updated changelog Signed-off-by: ahmedsobeh <ahmed.sobeh@aiven.io> * updated changelog Signed-off-by: ahmedsobeh <ahmed.sobeh@aiven.io> --------- Signed-off-by: ahmedsobeh <ahmed.sobeh@aiven.io> (cherry picked from commit 17b7996) Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
reta
force-pushed
the
backport/backport-14722-to-1.x
branch
from
0d48870
to
cffadba
Compare
|
❌ Gradle check result for 0d48870: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 1.x #14727 +/- ##
============================================
- Coverage 77.63% 77.61% -0.02%
+ Complexity 58824 58815 -9
============================================
Files 4223 4223
Lines 253567 253569 +2
Branches 38700 38700
============================================
- Hits 196860 196814 -46
- Misses 40700 40759 +59
+ Partials 16007 15996 -11 ☔ View full report in Codecov by Sentry. |
|
Should we backport to 1.x? I think 1.3 backport should be fine #14728. Wdyt? |
Hard to say what we have in mind for 1.x, we keep it around, so backporting ... thanks @owaiskazi19 |
owaiskazi19
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 17b7996 from #14722.