Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] Add capability to disable source recovery_source for an index (#13590) #14064

Merged
merged 1 commit into from
Jun 11, 2024
Merged

[Backport 2.x] Add capability to disable source recovery_source for an index (#13590) #14064

merged 1 commit into from
Jun 11, 2024

Conversation

navneet1v
Copy link
Contributor

Description

Backport of the PR: #13590

Related Issues

NA

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@navneet1v navneet1v added v2.15.0 Issues and PRs related to version 2.15.0 enhancement Enhancement or improvement to existing feature or request Indexing:Performance labels Jun 7, 2024
@navneet1v
Copy link
Contributor Author

@reta , @msfroh can I get a review on this backport PR. The automated backport failed.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 7, 2024

❌ Gradle check result for 05b4b6b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 7, 2024

❌ Gradle check result for d576b6a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@reta
Copy link
Collaborator

reta commented Jun 7, 2024

@reta , @msfroh can I get a review on this backport PR. The automated backport failed.

@navneet1v sure, needs #14072 :(

@navneet1v
Copy link
Contributor Author

@reta , @msfroh can I get a review on this backport PR. The automated backport failed.

@navneet1v sure, needs #14072 :(

Oh. will wait for your PR to be merged and will trigger gradle check again.

@navneet1v
Copy link
Contributor Author

❌ Gradle check result for 7dbc163: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

trying again.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 8, 2024

❌ Gradle check result for c91a26a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@navneet1v
Copy link
Contributor Author

❌ Gradle check result for c91a26a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Flaky test: #13828

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 8, 2024

❌ Gradle check result for ca1b7e9: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 9, 2024

❌ Gradle check result for a4e4540: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for b27a5b4: TIMEOUT

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for d152e4a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@andrross
Copy link
Member

❌ Gradle check result for d152e4a: FAILURE

#12197

@navneet1v
Copy link
Contributor Author

@andrross should I do a force push again to re-run gradle check.. :(

@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for d152e4a: SUCCESS

@codecov Codecov
Copy link

codecov bot commented Jun 11, 2024

Codecov Report

Attention: Patch coverage is 93.75000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 71.37%. Comparing base (0dd892c) to head (d152e4a).
Report is 340 commits behind head on 2.x.

Files Patch % Lines
...org/opensearch/index/mapper/SourceFieldMapper.java 93.75% 0 Missing and 2 partials ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##                2.x   #14064      +/-   ##
============================================
+ Coverage     71.28%   71.37%   +0.09%     
- Complexity    60145    61821    +1676     
============================================
  Files          4957     5071     +114     
  Lines        282799   290423    +7624     
  Branches      41409    42342     +933     
============================================
+ Hits         201591   207298    +5707     
- Misses        64189    65691    +1502     
- Partials      17019    17434     +415

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@navneet1v
Copy link
Contributor Author

@andrross, @reta , @msfroh I can see a successful gradle check. can we merge this PR?

@shwetathareja shwetathareja merged commit 6de0fae into opensearch-project:2.x Jun 11, 2024
31 checks passed
This was referenced Jun 13, 2024
Open
Open
Open
Open
Open
Open
Open
Open
@prudhvigodithi prudhvigodithi mentioned this pull request Jun 14, 2024
Closed
kkewwei pushed a commit to kkewwei/OpenSearch that referenced this pull request Jul 24, 2024
@navneet1v @kkewwei
Add capability to disable source recovery_source for an index (opense…
c04d612 
…arch-project#13590) (opensearch-project#14064)

Signed-off-by: Navneet Verma <navneev@amazon.com>
Signed-off-by: kkewwei <kkewwei@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reta reta reta approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@tlfeng tlfeng Awaiting requested review from tlfeng

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

Assignees
No one assigned
Labels
enhancement Enhancement or improvement to existing feature or request Indexing:Performance v2.15.0 Issues and PRs related to version 2.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@navneet1v @reta @andrross @shwetathareja