Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A documentation issue, used CONTRIBUTING.md instead of DEVELOPER_GUIDE.md #14028

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

akolarkunnu
Copy link
Contributor

Description:
Replaced CONTRIBUTING.md with DEVELOPER_GUIDE.md

Resolves #13984

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…E.md

Description:
Replaced CONTRIBUTING.md with DEVELOPER_GUIDE.md

Resolves opensearch-project#13984

Signed-off-by: Abdul Muneer Kolarkunnu <muneer.kolarkunnu@netapp.com>
Copy link
Contributor

github-actions bot commented Jun 6, 2024

❌ Gradle check result for 252c3e6: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@akolarkunnu
Copy link
Contributor Author

Known flaky org.opensearch.indices.IndicesRequestCacheIT.testDeleteAndCreateSameIndexShardOnSameNode {p0={"opensearch.experimental.feature.pluggable.caching.enabled":"false"}} - #13792
Known flaky org.opensearch.indices.IndicesRequestCacheIT.testDeleteAndCreateSameIndexShardOnSameNode {p0={"search.concurrent_segment_search.enabled":"false"}} - #13600
Known flaky org.opensearch.indices.IndicesRequestCacheIT.testDeleteAndCreateSameIndexShardOnSameNode {p0={"search.concurrent_segment_search.enabled":"true"}} - #13600
Known flaky org.opensearch.indices.IndicesRequestCacheIT.testDeleteAndCreateSameIndexShardOnSameNode {p0={"opensearch.experimental.feature.pluggable.caching.enabled":"true"}} - #13792

@akolarkunnu
Copy link
Contributor Author

akolarkunnu commented Jun 6, 2024

Can anyone help me to rerun the test suite which is failed ?
Also please add label "skip-changelog", since it's just a documentation change.

@reta reta added the backport 2.x Backport to 2.x branch label Jun 6, 2024
@reta
Copy link
Collaborator

reta commented Jun 6, 2024

Thank you @akolarkunnu !

Copy link
Contributor

github-actions bot commented Jun 6, 2024

✅ Gradle check result for 252c3e6: SUCCESS

Copy link

codecov bot commented Jun 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.71%. Comparing base (b15cb0c) to head (252c3e6).
Report is 354 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #14028      +/-   ##
============================================
+ Coverage     71.42%   71.71%   +0.29%     
- Complexity    59978    61443    +1465     
============================================
  Files          4985     5071      +86     
  Lines        282275   288403    +6128     
  Branches      40946    41764     +818     
============================================
+ Hits         201603   206827    +5224     
- Misses        63999    64531     +532     
- Partials      16673    17045     +372     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reta reta merged commit 8599065 into opensearch-project:main Jun 6, 2024
55 of 58 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 6, 2024
…E.md (#14028)

Description:
Replaced CONTRIBUTING.md with DEVELOPER_GUIDE.md

Resolves #13984

Signed-off-by: Abdul Muneer Kolarkunnu <muneer.kolarkunnu@netapp.com>
(cherry picked from commit 8599065)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
reta pushed a commit that referenced this pull request Jun 6, 2024
…E.md (#14028) (#14036)

Description:
Replaced CONTRIBUTING.md with DEVELOPER_GUIDE.md

Resolves #13984


(cherry picked from commit 8599065)

Signed-off-by: Abdul Muneer Kolarkunnu <muneer.kolarkunnu@netapp.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
parv0201 pushed a commit to parv0201/OpenSearch that referenced this pull request Jun 10, 2024
…E.md (opensearch-project#14028)

Description:
Replaced CONTRIBUTING.md with DEVELOPER_GUIDE.md

Resolves opensearch-project#13984

Signed-off-by: Abdul Muneer Kolarkunnu <muneer.kolarkunnu@netapp.com>
kkewwei pushed a commit to kkewwei/OpenSearch that referenced this pull request Jul 24, 2024
…E.md (opensearch-project#14028) (opensearch-project#14036)

Description:
Replaced CONTRIBUTING.md with DEVELOPER_GUIDE.md

Resolves opensearch-project#13984

(cherry picked from commit 8599065)

Signed-off-by: Abdul Muneer Kolarkunnu <muneer.kolarkunnu@netapp.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: kkewwei <kkewwei@163.com>
wdongyu pushed a commit to wdongyu/OpenSearch that referenced this pull request Aug 22, 2024
…E.md (opensearch-project#14028)

Description:
Replaced CONTRIBUTING.md with DEVELOPER_GUIDE.md

Resolves opensearch-project#13984

Signed-off-by: Abdul Muneer Kolarkunnu <muneer.kolarkunnu@netapp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch bug Something isn't working Other skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] A documentation issue, used CONTRIBUTING.md instead of DEVELOPER_GUIDE.md
3 participants