Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Prefer remote replicas for primary promotion during migration (#13136) #13377

Merged

Conversation

ltaragi
Copy link
Contributor

@ltaragi ltaragi commented Apr 25, 2024

Signed-off-by: Lakshya Taragi lakshya.taragi@gmail.com
(cherry picked from commit efa06fe)

Description

Backport #13136 to 2.x

Related Issues

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…arch-project#13136)

Signed-off-by: Lakshya Taragi <lakshya.taragi@gmail.com>
(cherry picked from commit efa06fe)
Copy link
Contributor

✅ Gradle check result for 6fbd941: SUCCESS

Copy link

codecov bot commented Apr 25, 2024

Codecov Report

Attention: Patch coverage is 78.57143% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 71.13%. Comparing base (0dd892c) to head (6fbd941).
Report is 177 commits behind head on 2.x.

Files Patch % Lines
...a/org/opensearch/cluster/routing/RoutingNodes.java 81.81% 0 Missing and 2 partials ⚠️
...earch/node/remotestore/RemoteStoreNodeService.java 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #13377      +/-   ##
============================================
- Coverage     71.28%   71.13%   -0.15%     
- Complexity    60145    60749     +604     
============================================
  Files          4957     5011      +54     
  Lines        282799   285865    +3066     
  Branches      41409    41776     +367     
============================================
+ Hits         201591   203361    +1770     
- Misses        64189    65409    +1220     
- Partials      17019    17095      +76     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gbbafna gbbafna merged commit 64909a3 into opensearch-project:2.x Apr 25, 2024
53 of 54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants