Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moving maintainer kartg to Emeritus #12550

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Moving maintainer kartg to Emeritus #12550

merged 1 commit into from
Mar 7, 2024

Conversation

kartg
Copy link
Member

@kartg kartg commented Mar 6, 2024 •
edited
Loading

Description

Moving maintainer kartg to Emeritus, and removing from CODEOWNERS

Related Issues

N/A

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 6, 2024 •
edited
Loading

Compatibility status:

Checks if related components are compatible with change 6031d38

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/performance-analyzer.git]

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 7, 2024

✅ Gradle check result for f0c23d9: SUCCESS

@codecov Codecov
Copy link

codecov bot commented Mar 7, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.48%. Comparing base (11836d0) to head (6031d38).

Additional details and impacted files 
@@             Coverage Diff              @@
##               main   #12550      +/-   ##
============================================
+ Coverage     71.32%   71.48%   +0.15%     
- Complexity    59887    59964      +77     
============================================
  Files          4982     4982              
  Lines        282152   282152              
  Branches      40940    40940              
============================================
+ Hits         201239   201685     +446     
+ Misses        64187    63749     -438     
+ Partials      16726    16718       -8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@owaiskazi19
Copy link
Member

owaiskazi19 commented Mar 7, 2024 •
edited
Loading

@kartg you might have to remove the alias from CODEOWNERS as well?

@kartg
Moving maintainer kartg to Emeritus
6031d38 
Also includes removal from CODEOWNERS

Signed-off-by: Kartik Ganesh <gkart@amazon.com>
@owaiskazi19
Copy link
Member

@opensearch-project/admin can you help to remove the permission here?

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 7, 2024

❌ Gradle check result for 6031d38: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@kartg
Copy link
Member Author

kartg commented Mar 7, 2024 •
edited
Loading

❌ Gradle check result for 6031d38: FAILURE

#10704 and #5329 (flaky tests), will refire

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 7, 2024

❕ Gradle check result for 6031d38: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.search.SearchWeightedRoutingIT.testMultiGetWithNetworkDisruption_FailOpenEnabled

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@andrross andrross merged commit 3056b67 into opensearch-project:main Mar 7, 2024
33 checks passed
@andrross andrross added the backport 2.x Backport to 2.x branch label Mar 7, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 7, 2024
@github-actions
Move maintainer kartg to Emeritus (#12550)
81302a5 
Also includes removal from CODEOWNERS

Signed-off-by: Kartik Ganesh <gkart@amazon.com>
(cherry picked from commit 3056b67)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Mar 7, 2024
Merged
@dblock
Copy link
Member

dblock commented Mar 7, 2024

@opensearch-project/admin can you help to remove the permission here?

Done.

dblock pushed a commit that referenced this pull request Mar 7, 2024
@opensearch-trigger-bot @github-actions
Move maintainer kartg to Emeritus (#12550) (#12551)
d2b951b 
Also includes removal from CODEOWNERS


(cherry picked from commit 3056b67)

Signed-off-by: Kartik Ganesh <gkart@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
amkhar pushed a commit to amkhar/OpenSearch that referenced this pull request Mar 12, 2024
@kartg
Move maintainer kartg to Emeritus (opensearch-project#12550)
5cc699e 
Also includes removal from CODEOWNERS

Signed-off-by: Kartik Ganesh <gkart@amazon.com>
Signed-off-by: Aman Khare <amkhar@amazon.com>
amkhar pushed a commit to amkhar/OpenSearch that referenced this pull request Mar 14, 2024
@kartg
Move maintainer kartg to Emeritus (opensearch-project#12550)
39b0d2b 
Also includes removal from CODEOWNERS

Signed-off-by: Kartik Ganesh <gkart@amazon.com>
rayshrey pushed a commit to rayshrey/OpenSearch that referenced this pull request Mar 18, 2024
@kartg @rayshrey
Move maintainer kartg to Emeritus (opensearch-project#12550)
c843109 
Also includes removal from CODEOWNERS

Signed-off-by: Kartik Ganesh <gkart@amazon.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
@kartg @shiv0408
Move maintainer kartg to Emeritus (opensearch-project#12550)
1d06c5c 
Also includes removal from CODEOWNERS

Signed-off-by: Kartik Ganesh <gkart@amazon.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peternied peternied peternied approved these changes

@andrross andrross andrross approved these changes

@owaiskazi19 owaiskazi19 owaiskazi19 approved these changes

@abbashus abbashus Awaiting requested review from abbashus

@adnapibar adnapibar Awaiting requested review from adnapibar

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@ryanbogan ryanbogan Awaiting requested review from ryanbogan

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@tlfeng tlfeng Awaiting requested review from tlfeng

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

Assignees
No one assigned
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kartg @owaiskazi19 @dblock @peternied @andrross