Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Fix for deserilization bug in weighted round robin metadata (#11679) #12545

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

anshu1106
Copy link
Contributor

@anshu1106 anshu1106 commented Mar 6, 2024


Description

[2.x Backport] Fix for deserialization bug in weighted round robin metadata
#11679

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…ch-project#11679)

* Fix for deserialization bug in weighted round robin metadata

Signed-off-by: Anshu Agarwal <anshukag@amazon.com>

---------

Signed-off-by: Anshu Agarwal <anshukag@amazon.com>
Co-authored-by: Anshu Agarwal <anshukag@amazon.com>
@anshu1106 anshu1106 changed the title Fix for deserilization bug in weighted round robin metadata (#11679) [Backport 2.x] Fix for deserilization bug in weighted round robin metadata (#11679) Mar 6, 2024
Copy link
Contributor

github-actions bot commented Mar 6, 2024

Compatibility status:

Checks if related components are compatible with change 290fbbb

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/performance-analyzer.git]

Copy link
Contributor

github-actions bot commented Mar 6, 2024

❕ Gradle check result for 290fbbb: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.action.admin.cluster.node.tasks.ResourceAwareTasksTests.testTaskResourceTrackingDuringTaskCancellation

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Mar 6, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 71.14%. Comparing base (d6dbcf7) to head (290fbbb).

Files Patch % Lines
...arch/cluster/metadata/WeightedRoutingMetadata.java 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #12545      +/-   ##
============================================
- Coverage     71.22%   71.14%   -0.09%     
- Complexity    60071    60086      +15     
============================================
  Files          4955     4955              
  Lines        282704   282704              
  Branches      41396    41397       +1     
============================================
- Hits         201352   201116     -236     
- Misses        64328    64594     +266     
+ Partials      17024    16994      -30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anshu1106
Copy link
Contributor Author

testTaskResourceTrackingDuringTaskCancellation

Flaky test - #5329

@sachinpkale sachinpkale merged commit 194f357 into opensearch-project:2.x Mar 8, 2024
88 of 89 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants