Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Segment Replication] Add random replication strategy #12297

Merged
merged 4 commits into from
Feb 21, 2024
Merged

[Segment Replication] Add random replication strategy #12297

merged 4 commits into from
Feb 21, 2024

Conversation

Rishikesh1159
Copy link
Member

@Rishikesh1159 Rishikesh1159 commented Feb 12, 2024 •
edited
Loading

Description

This PR enables the support of random replication strategy for integration tests. This helps to increase the segment replication test coverage by randomly selecting replication strategy for tests not critical of replication strategy.

Related Issues

Resolves #12261

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@Rishikesh1159 Rishikesh1159 marked this pull request as ready for review February 12, 2024 23:45
@github-actions github-actions bot added enhancement Enhancement or improvement to existing feature or request Indexing:Replication Issues and PRs related to core replication framework eg segrep labels Feb 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 13, 2024 •
edited
Loading

Compatibility status:

Checks if related components are compatible with change 6951ea2

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/performance-analyzer.git]

@github-actions GitHub Actions
Copy link
Contributor

❕ Gradle check result for ba618e2: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.remotestore.RemoteIndexPrimaryRelocationIT.testPrimaryRelocationWhileIndexing

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@codecov Codecov
Copy link

codecov bot commented Feb 13, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (76ae14a) 71.41% compared to head (6951ea2) 71.44%.
Report is 17 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main   #12297      +/-   ##
============================================
+ Coverage     71.41%   71.44%   +0.03%     
- Complexity    59813    59863      +50     
============================================
  Files          4959     4959              
  Lines        281126   281126              
  Branches      40857    40857              
============================================
+ Hits         200753   200847      +94     
+ Misses        63731    63639      -92     
+ Partials      16642    16640       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Rishikesh1159
Add replication strategy logging.
6951ea2 
Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>
@github-actions GitHub Actions
Copy link
Contributor

❕ Gradle check result for 6951ea2: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.cluster.MinimumClusterManagerNodesIT.testThreeNodesNoClusterManagerBlock

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@andrross andrross added the backport 2.x Backport to 2.x branch label Feb 21, 2024
@andrross andrross merged commit f8225ca into opensearch-project:main Feb 21, 2024
35 of 38 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 21, 2024
@github-actions
[Segment Replication] Add random replication strategy (#12297)
0a93e45 
* Add new method to pick a random replication strategy.

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>

* replace usage of refresh with refreshandWaitForReplication()

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>

* Add replication strategy logging.

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>

---------

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>
(cherry picked from commit f8225ca)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Feb 21, 2024
Merged
Rishikesh1159 pushed a commit that referenced this pull request Feb 22, 2024
@opensearch-trigger-bot @github-actions
[Segment Replication] Add random replication strategy (#12297) (#12425)
6aeba1f 
* Add new method to pick a random replication strategy.



* replace usage of refresh with refreshandWaitForReplication()



* Add replication strategy logging.



---------


(cherry picked from commit f8225ca)

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@Rishikesh1159 Rishikesh1159 mentioned this pull request Feb 28, 2024
Open
peteralfonsi pushed a commit to peteralfonsi/OpenSearch that referenced this pull request Mar 1, 2024
@Rishikesh1159
[Segment Replication] Add random replication strategy (opensearch-pro…
09c2fcb 
…ject#12297)

* Add new method to pick a random replication strategy.

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>

* replace usage of refresh with refreshandWaitForReplication()

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>

* Add replication strategy logging.

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>

---------

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>
amkhar pushed a commit to amkhar/OpenSearch that referenced this pull request Mar 12, 2024
@Rishikesh1159
[Segment Replication] Add random replication strategy (opensearch-pro…
f9f1999 
…ject#12297)

* Add new method to pick a random replication strategy.

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>

* replace usage of refresh with refreshandWaitForReplication()

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>

* Add replication strategy logging.

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>

---------

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>
Signed-off-by: Aman Khare <amkhar@amazon.com>
rayshrey pushed a commit to rayshrey/OpenSearch that referenced this pull request Mar 18, 2024
@Rishikesh1159 @rayshrey
[Segment Replication] Add random replication strategy (opensearch-pro…
43a6e35 
…ject#12297)

* Add new method to pick a random replication strategy.

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>

* replace usage of refresh with refreshandWaitForReplication()

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>

* Add replication strategy logging.

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>

---------

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
@Rishikesh1159 @shiv0408
[Segment Replication] Add random replication strategy (opensearch-pro…
0dbdb15 
…ject#12297)

* Add new method to pick a random replication strategy.

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>

* replace usage of refresh with refreshandWaitForReplication()

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>

* Add replication strategy logging.

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>

---------

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ansjcy ansjcy ansjcy left review comments

@kkmr kkmr kkmr approved these changes

@andrross andrross andrross approved these changes

@abbashus abbashus Awaiting requested review from abbashus

@adnapibar adnapibar Awaiting requested review from adnapibar

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@kartg kartg Awaiting requested review from kartg

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@ryanbogan ryanbogan Awaiting requested review from ryanbogan

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@tlfeng tlfeng Awaiting requested review from tlfeng

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

Assignees
No one assigned
Labels
backport 2.x Backport to 2.x branch enhancement Enhancement or improvement to existing feature or request Indexing:Replication Issues and PRs related to core replication framework eg segrep skip-changelog
Projects
None yet
Milestone
No milestone
4 participants
@Rishikesh1159 @kkmr @ansjcy @andrross