Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deleted doc count in _cat/shards #11678

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

rayshrey
Copy link
Contributor

@rayshrey rayshrey commented Dec 27, 2023

Description

Added deleted document count in _cat/shards.
Kept is as a non-default column for now (docs.deleted will only be returned if present in the header parameter)

_cat/shards?v

index  shard prirep state      docs  store   ip        node
index1 0     p      STARTED       4    4.4kb 127.0.0.1 b0be8357b2c9.ant.amazon.com                             
index3 0     p      STARTED       2    4.3kb 127.0.0.1 b0be8357b2c9.ant.amazon.com                              
index2 0     p      STARTED       3    4.3kb 127.0.0.1 b0be8357b2c9.ant.amazon.com       


_cat/shards?v&h=index,shard,prirep,state,docs,docs.deleted,store,ip,node

index  shard prirep state      docs docs.deleted store ip        node
index1 0     p      STARTED       4            0  4.4kb 127.0.0.1 b0be8357b2c9.ant.amazon.com                             
index3 0     p      STARTED       2            0  4.3kb 127.0.0.1 b0be8357b2c9.ant.amazon.com                              
index2 0     p      STARTED       3            0  4.3kb 127.0.0.1 b0be8357b2c9.ant.amazon.com 
                  

Related Issues

Resolves #11677

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

github-actions bot commented Dec 27, 2023

Compatibility status:

Checks if related components are compatible with change 0fef3ca

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/sql.git]

Copy link
Contributor

❌ Gradle check result for c73a668: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Jan 2, 2024

❌ Gradle check result for 45eeed8: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Jan 2, 2024

✅ Gradle check result for eef855b: SUCCESS

@github-actions github-actions bot added the WIP Work in progress label Jan 3, 2024
Copy link
Contributor

github-actions bot commented Jan 3, 2024

❌ Gradle check result for c6f43f5: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Shreyansh Ray <rayshrey@amazon.com>
Copy link
Contributor

github-actions bot commented Jan 3, 2024

✅ Gradle check result for 0fef3ca: SUCCESS

@rayshrey
Copy link
Contributor Author

rayshrey commented Jan 3, 2024

@reta done with all the necessary changes. Can you please review and merge the PR

@reta
Copy link
Collaborator

reta commented Jan 3, 2024

@reta done with all the necessary changes. Can you please review and merge the PR

Thanks @rayshrey , asking signoff from @mgodwan since he asked for changes

@mgodwan
Copy link
Member

mgodwan commented Jan 4, 2024

LGTM. Approved the changes

@reta reta removed the WIP Work in progress label Jan 4, 2024
@reta reta merged commit 36bd674 into opensearch-project:main Jan 4, 2024
31 checks passed
@reta reta added backport 2.x Backport to 2.x branch v3.0.0 Issues and PRs related to version 3.0.0 labels Jan 4, 2024
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-11678-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 36bd67465a12bbc56631f49a617429529a8365f9
# Push it to GitHub
git push --set-upstream origin backport/backport-11678-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-11678-to-2.x.

@reta
Copy link
Collaborator

reta commented Jan 4, 2024

@rayshrey could you please backport manually to 2.x? thank you!

rayshrey added a commit to rayshrey/OpenSearch that referenced this pull request Mar 18, 2024
Signed-off-by: Shreyansh Ray <rayshrey@amazon.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
Signed-off-by: Shreyansh Ray <rayshrey@amazon.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch backport-failed enhancement Enhancement or improvement to existing feature or request Other v2.12.0 Issues and PRs related to version 2.12.0 v3.0.0 Issues and PRs related to version 3.0.0
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

_cat/shards does not show deleted document count
5 participants