Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky test in CardinalityWithRequestBreakerIT #11467

Closed

Conversation

neetikasinghal
Copy link
Contributor

Description

Specifying the annotation on the IT test helps resolve the flaky test.

Related Issues

Resolves #[Issue number to be closed when this PR is merged]
#10154

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Neetika Singhal <neetiks@amazon.com>
@neetikasinghal
Copy link
Contributor Author

@sohami @jed326 please review.

Copy link
Contributor

github-actions bot commented Dec 5, 2023

Compatibility status:

Checks if related components are compatible with change f4275aa

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/sql.git]

Copy link
Contributor

github-actions bot commented Dec 5, 2023

❕ Gradle check result for f4275aa: UNSTABLE

  • TEST FAILURES:
      2 org.opensearch.common.util.concurrent.QueueResizableOpenSearchThreadPoolExecutorTests.classMethod
      1 org.opensearch.common.util.concurrent.QueueResizableOpenSearchThreadPoolExecutorTests.testResizeQueueDown

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Dec 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f7f3500) 71.37% compared to head (f4275aa) 70.63%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #11467      +/-   ##
============================================
- Coverage     71.37%   70.63%   -0.74%     
+ Complexity    59113    58496     -617     
============================================
  Files          4893     4893              
  Lines        277831   277831              
  Branches      40367    40367              
============================================
- Hits         198288   196247    -2041     
- Misses        63042    65126    +2084     
+ Partials      16501    16458      -43     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -54,6 +55,7 @@
import static org.opensearch.search.aggregations.AggregationBuilders.cardinality;
import static org.opensearch.search.aggregations.AggregationBuilders.terms;

@OpenSearchIntegTestCase.ClusterScope(scope = OpenSearchIntegTestCase.Scope.SUITE)
Copy link
Collaborator

@reta reta Dec 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@neetikasinghal apologies, how does it solve the issue? The Scope.SUITE is the default value for scope , is it overridden somewhere down the hierarchy? (I was not able to find where)

@neetikasinghal
Copy link
Contributor Author

This doesnt look to be the right fix, closing this pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants