Guice resection

[nknize]

Surgically removes malignant Guice code.

o.o.common.inject is a fork of Guice 2.0 from many moons ago. It is used to create type safe instances at runtime w/o the need for Factories. Most of the functionality has been removed prior to forking OpenSearch. This housecleaning commit removes stale code that is either not called or unnecessarily called through the Injector logic path.

relates #5910
relates #8110

[github-actions]

Compatibility status:

Checks if related components are compatible with change 4e2ffd0

Incompatible components

Incompatible components: [https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/performance-analyzer.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git]

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/28993/
• CommitID: 4e2ffd0
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[nknize]

Ah, Jenkins serving up another healthy bowl.

[reta]

@nknize nice cleanup, we need changelog for it please.

Also, please notice this change is breaking (I've added label to the pull request): the Binder leaks through Plugin::createGuiceModules, we should acknowledge that.

[nknize]

the Binder leaks through Plugin::createGuiceModules.

hideous... that was removed from Elasticsearch a long long time ago. I forgot that it was only merged into 8.0 and we didn't inherit when we forked 7.10.2.

...we should acknowledge that.

+1. I'm going to acknowledge it a step further by deprecating and removing that trappy method from Plugin altogether (in a followup PR). Bless any plugin that customized this guice injection framework since it's been walking the green mile for years.

[dblock]

Also, please notice this change is breaking (I've added label to the pull request): the Binder leaks through Plugin::createGuiceModules, we should acknowledge that.

Given conversations such as #5902 (comment), what do you think about introducing an UPGRADING.md that would include both dev and end-user breaking changes? e.g. https://github.com/opensearch-project/opensearch-py/blob/main/UPGRADING.md.

[nknize]

...what do you think about introducing an UPGRADING.md that would include both dev and end-user breaking changes?

No objection so long as it doesn't add "one more thing" to maintainers todo list. The learning curve to contribute is already quite high.

[opensearch-trigger-bot]

This PR is stalled because it has been open for 30 days with no activity.

[ticheng-aws]

Hi @nknize, the PR is stalled. Do we have any updates?

[opensearch-trigger-bot]

This PR is stalled because it has been open for 30 days with no activity.

[stephen-crawford]

@opensearch-project/opensearch-core do we have plans to continue this work? It does not seem like this PR is going to be moved forward by Nick at the moment, so if we want to move forward someone else may need to pick up where this was left off. Otherwise we should close this.

What is the path forward?

[reta]

What is the path forward?

I would give the author the time to finish it (or let it be closed and reopened later). Nick seems to have much better context why the things have been done this way and what the right way is.

[stephen-crawford]

Hi @reta, thanks for following up. Is there a timeframe OpenSearch's maintainers have decided is reasonable for closing stalled PRs? I know there is the auto comment bot, but I think that was turned off; is it 6 months of inactivity like maintainership or just up to discretion?

[reta]

I know there is the auto comment bot, but I think that was turned off;

I think it is on actually

[opensearch-trigger-bot]

This PR is stalled because it has been open for 30 days with no activity.

[nknize]

won't be actively working unless needed... too much divergence and code fragmentation at this point. Let me know if anyone is interested in burning this fat in the future.