Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Draft] Search Query Categorizor initial skeleton using QueryBuilderVisitor #10255

Closed

Integrate metrics framework, refactor code and update tests

3338d4f
Select commit
Loading
Failed to load commit list.
Closed

[Draft] Search Query Categorizor initial skeleton using QueryBuilderVisitor #10255

Integrate metrics framework, refactor code and update tests
3338d4f
Select commit
Loading
Failed to load commit list.
DCO / DCO required action Oct 9, 2023 in 1s

DCO

There are 24 commits incorrectly signed off. This means that the author(s) of these commits failed to include a Signed-off-by line in their commit message.

To avoid having PRs blocked in the future, always include Signed-off-by: Author Name <authoremail@example.com> in every commit message. You can also do this automatically by using the -s flag (i.e., git commit -s).

Here is how to fix the problem so that this code can be merged.


Rebase the branch

If you have a local git environment and meet the criteria below, one option is to rebase the branch and add your Signed-off-by lines in the new commits. Please note that if others have already begun work based upon the commits in this branch, this solution will rewrite history and may cause serious issues for collaborators (described in the git documentation under "The Perils of Rebasing").

You should only do this if:

  • You are the only author of the commits in this branch
  • You are absolutely certain nobody else is doing any work based upon this branch
  • There are no empty commits in the branch (for example, a DCO Remediation Commit which was added using --allow-empty)

To add your Signed-off-by line to every commit in this branch:

  1. Ensure you have a local copy of your branch by checking out the pull request locally via command line.
  2. In your local branch, run: git rebase HEAD~65 --signoff
  3. Force push your changes to overwrite the branch: git push --force-with-lease origin sid/search-query-categorizor

Summary

Commit sha: e7a9fb0, Author: Ashish, Committer: Siddhant Deshmukh; Can not find "Ashish ssashish@amazon.com", in ["Ashish Singh ssashish@amazon.com", "Ashish Singh ssashish@amazon.com", "Ashish Singh ssashish@amazon.com"].
Commit sha: 6786c36, Author: Ashish, Committer: Siddhant Deshmukh; Expected "Ashish ssashish@amazon.com", but got "Ashish Singh ssashish@amazon.com".
Commit sha: 76293c6, Author: Ashish, Committer: Siddhant Deshmukh; Expected "Ashish ssashish@amazon.com", but got "Ashish Singh ssashish@amazon.com".
Commit sha: c3440ba, Author: Ashish, Committer: Siddhant Deshmukh; Expected "Ashish ssashish@amazon.com", but got "Ashish Singh ssashish@amazon.com".
Commit sha: 17c32af, Author: Ashish, Committer: Siddhant Deshmukh; Expected "Ashish ssashish@amazon.com", but got "Ashish Singh ssashish@amazon.com".
Commit sha: d8666f0, Author: Ashish, Committer: Siddhant Deshmukh; Expected "Ashish ssashish@amazon.com", but got "Ashish Singh ssashish@amazon.com".
Commit sha: 747d108, Author: Craig Perkins, Committer: Siddhant Deshmukh; The sign-off is missing.
Commit sha: 5f0dc56, Author: Daniel (dB.) Doubrovkine, Committer: Siddhant Deshmukh; Can not find "Daniel (dB.) Doubrovkine dblock@amazon.com", in ["dblock dblock@amazon.com", "dblock dblock@amazon.com", "dblock dblock@amazon.com", "dblock dblock@amazon.com"].
Commit sha: cf1fa2d, Author: Dharmesh, Committer: Siddhant Deshmukh; Expected "Dharmesh sdharms@amazon.com", but got "Dharmesh 💤 sdharms@amazon.com".
Commit sha: ad110b9, Author: Gagan Juneja, Committer: Siddhant Deshmukh; Expected "Gagan Juneja gagandeepjuneja@gmail.com", but got "Gagan Juneja gjjuneja@amazon.com".
Commit sha: 66fbf2d, Author: gaobinlong, Committer: Siddhant Deshmukh; Can not find "gaobinlong gbinlong@amazon.com", in ["Gao Binlong gbinlong@amazon.com", "Gao Binlong gbinlong@amazon.com", "Gao Binlong gbinlong@amazon.com", "Gao Binlong gbinlong@amazon.com", "Daniel (dB.) Doubrovkine dblock@amazon.com"].
Commit sha: 5b68b89, Author: Gaurav Bafna, Committer: Siddhant Deshmukh; Can not find "Gaurav Bafna 85113518+gbbafna@users.noreply.github.com", in ["Gaurav Bafna gbbafna@amazon.com", "Gaurav Bafna gbbafna@amazon.com", "Gaurav Bafna gbbafna@amazon.com", "Gaurav Bafna gbbafna@amazon.com", "Gaurav Bafna gbbafna@amazon.com", "Gaurav Bafna gbbafna@amazon.com", "Gaurav Bafna gbbafna@amazon.com", "Gaurav Bafna gbbafna@amazon.com", "Gaurav Bafna gbbafna@amazon.com", "Gaurav Bafna gbbafna@amazon.com", "Gaurav Bafna gbbafna@amazon.com", "Gaurav Bafna gbbafna@amazon.com", "Gaurav Bafna gbbafna@amazon.com"].
Commit sha: 312c536, Author: Gaurav Bafna, Committer: Siddhant Deshmukh; Expected "Gaurav Bafna 85113518+gbbafna@users.noreply.github.com", but got "Gaurav Bafna gbbafna@amazon.com".
Commit sha: a024901, Author: Harish Bhakuni, Committer: Siddhant Deshmukh; Can not find "Harish Bhakuni harishbhakuni21@gmail.com", in ["Harish Bhakuni hbhakuni@amazon.com", "Harish Bhakuni hbhakuni@amazon.com", "Harish Bhakuni hbhakuni@amazon.com", "Harish Bhakuni hbhakuni@amazon.com", "Harish Bhakuni hbhakuni@amazon.com", "Harish Bhakuni hbhakuni@amazon.com", "Harish Bhakuni hbhakuni@amazon.com"].
Commit sha: 281b841, Author: Prabhat, Committer: Siddhant Deshmukh; Can not find "Prabhat 20185657+CaptainDredge@users.noreply.github.com", in ["Prabhat Sharma ptsharma@amazon.com", "Prabhat Sharma ptsharma@amazon.com", "Prabhat Sharma ptsharma@amazon.com"].
Commit sha: 76da117, Author: Prabhat, Committer: Siddhant Deshmukh; Can not find "Prabhat 20185657+CaptainDredge@users.noreply.github.com", in ["Prabhat Sharma ptsharma@amazon.com", "Prabhat Sharma ptsharma@amazon.com", "Prabhat Sharma ptsharma@amazon.com"].
Commit sha: 6219da7, Author: rishavz_sagar, Committer: Siddhant Deshmukh; Expected "rishavz_sagar rishavsagar4b1@gmail.com", but got "Rishav Sagar rissag@amazon.com".
Commit sha: 9707d27, Author: rishavz_sagar, Committer: Siddhant Deshmukh; Expected "rishavz_sagar rishavsagar4b1@gmail.com", but got "Rishav Sagar rissag@amazon.com".
Commit sha: 2580dfc, Author: Rishikesh Pasham, Committer: Siddhant Deshmukh; Can not find "Rishikesh Pasham 62345295+Rishikesh1159@users.noreply.github.com", in ["Rishikesh1159 rishireddy1159@gmail.com", "Rishikesh1159 rishireddy1159@gmail.com", "Rishikesh1159 rishireddy1159@gmail.com"].
Commit sha: 8f859ef, Author: Sachin Kale, Committer: Siddhant Deshmukh; Expected "Sachin Kale sachinpkale@gmail.com", but got "Sachin Kale kalsac@amazon.com".
Commit sha: 380765e, Author: Sagar, Committer: Siddhant Deshmukh; Can not find "Sagar 99425694+sgup432@users.noreply.github.com", in ["Sagar Upadhyaya sagar.upadhyaya.121@gmail.com", "Rohit Ashiwal rashiwal@amazon.com", "github-actions[bot] <github-actions[bot]@users.noreply.github.com>", "Rohit Ashiwal rashiwal@amazon.com", "Sagar Upadhyaya sagar.upadhyaya.121@gmail.com", "Sagar Upadhyaya sagar.upadhyaya.121@gmail.com", "Rohit Ashiwal rashiwal@amazon.com", "github-actions[bot] <github-actions[bot]@users.noreply.github.com>"].
Commit sha: 6995db5, Author: Sagar, Committer: Siddhant Deshmukh; Expected "Sagar 99425694+sgup432@users.noreply.github.com", but got "Sagar Upadhyaya sagar.upadhyaya.121@gmail.com".
Commit sha: 8ec6e90, Author: Varun Bansal, Committer: Siddhant Deshmukh; Can not find "Varun Bansal bansvaru@amazon.com", in ["bansvaru bansvaru@amazon.com", "bansvaru bansvaru@amazon.com", "bansvaru bansvaru@amazon.com", "bansvaru bansvaru@amazon.com", "bansvaru bansvaru@amazon.com", "bansvaru bansvaru@amazon.com", "bansvaru bansvaru@amazon.com", "bansvaru bansvaru@amazon.com", "bansvaru bansvaru@amazon.com", "bansvaru bansvaru@amazon.com", "bansvaru bansvaru@amazon.com"].
Commit sha: 179e53b, Author: Vikas Bansal, Committer: Siddhant Deshmukh; Expected "Vikas Bansal 43470111+vikasvb90@users.noreply.github.com", but got "vikasvb90 vikasvb@amazon.com".