Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script Score Query Builder Visit Method #10198

Merged
merged 3 commits into from
Sep 25, 2023
Merged

Script Score Query Builder Visit Method #10198

merged 3 commits into from
Sep 25, 2023

Conversation

vibrantvarun
Copy link
Member

Description

Adding Visit method in Script Score Query Builder. I missed it in my earlier PR #10110

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Varun Jain <varunudr@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Sep 23, 2023

Compatibility status:

Checks if related components are compatible with change cf308d0

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/reporting.git]

Signed-off-by: Varun Jain <varunudr@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: Varun Jain <varunudr@amazon.com>
@msfroh
Copy link
Collaborator

msfroh commented Sep 25, 2023

Looks like Spotless is failing:

* What went wrong:
Execution failed for task ':server:spotlessJavaCheck'.
> The following files had format violations:
      src/test/java/org/opensearch/index/query/ScriptScoreQueryBuilderTests.java
          @@ -32,8 +32,6 @@
           
           package·org.opensearch.index.query;
           
          -import·java.util.ArrayList;
          -import·java.util.List;
           import·org.apache.lucene.search.MatchNoDocsQuery;
           import·org.apache.lucene.search.Query;
           import·org.opensearch.OpenSearchException;
          @@ -45,7 +43,9 @@
           import·org.opensearch.test.AbstractQueryTestCase;
           
           import·java.io.IOException;
          +import·java.util.ArrayList;
           import·java.util.Collections;
          +import·java.util.List;
           
           import·static·org.opensearch.index.query.QueryBuilders.matchAllQuery;
           import·static·org.hamcrest.CoreMatchers.instanceOf;
  Run './gradlew :server:spotlessApply' to fix these violations.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.snapshots.CloneSnapshotIT.testCloneAfterRepoShallowSettingDisabled
      1 org.opensearch.repositories.azure.AzureBlobContainerRetriesTests.testWriteLargeBlob
      1 org.opensearch.remotestore.RemoteStoreStatsIT.testDownloadStatsCorrectnessSinglePrimaryMultipleReplicaShards

@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Merging #10198 (cf308d0) into main (c4c4ad8) will decrease coverage by 0.12%.
Report is 8 commits behind head on main.
The diff coverage is 80.00%.

@@             Coverage Diff              @@
##               main   #10198      +/-   ##
============================================
- Coverage     71.20%   71.09%   -0.12%     
+ Complexity    58257    58186      -71     
============================================
  Files          4828     4828              
  Lines        274385   274390       +5     
  Branches      39988    39989       +1     
============================================
- Hits         195386   195077     -309     
- Misses        62616    62969     +353     
+ Partials      16383    16344      -39     
Files Coverage Δ
...x/query/functionscore/ScriptScoreQueryBuilder.java 86.25% <80.00%> (-0.42%) ⬇️

... and 475 files with indirect coverage changes

@msfroh msfroh merged commit a8969cb into opensearch-project:main Sep 25, 2023
13 checks passed
@vibrantvarun vibrantvarun added the backport 2.x Backport to 2.x branch label Sep 25, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 25, 2023
* Script Score Builder Visit Method

Signed-off-by: Varun Jain <varunudr@amazon.com>

* ScriptScore Query Builder Visit Method

Signed-off-by: Varun Jain <varunudr@amazon.com>

* gradlew spotlessApply

Signed-off-by: Varun Jain <varunudr@amazon.com>

---------

Signed-off-by: Varun Jain <varunudr@amazon.com>
(cherry picked from commit a8969cb)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ryanbogan pushed a commit that referenced this pull request Sep 26, 2023
* Script Score Builder Visit Method



* ScriptScore Query Builder Visit Method



* gradlew spotlessApply



---------


(cherry picked from commit a8969cb)

Signed-off-by: Varun Jain <varunudr@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
vikasvb90 pushed a commit to vikasvb90/OpenSearch that referenced this pull request Oct 10, 2023
* Script Score Builder Visit Method

Signed-off-by: Varun Jain <varunudr@amazon.com>

* ScriptScore Query Builder Visit Method

Signed-off-by: Varun Jain <varunudr@amazon.com>

* gradlew spotlessApply

Signed-off-by: Varun Jain <varunudr@amazon.com>

---------

Signed-off-by: Varun Jain <varunudr@amazon.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
* Script Score Builder Visit Method

Signed-off-by: Varun Jain <varunudr@amazon.com>

* ScriptScore Query Builder Visit Method

Signed-off-by: Varun Jain <varunudr@amazon.com>

* gradlew spotlessApply

Signed-off-by: Varun Jain <varunudr@amazon.com>

---------

Signed-off-by: Varun Jain <varunudr@amazon.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants