Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Remote Store] Refactor Translog metadata upload/download to write/read header and footer via VersionedCodecStreamWrapper #7228

Closed
linuxpi opened this issue Apr 18, 2023 · 0 comments · Fixed by #7953
Closed

[Remote Store] Refactor Translog metadata upload/download to write/read header and footer via VersionedCodecStreamWrapper #7228

linuxpi opened this issue Apr 18, 2023 · 0 comments · Fixed by #7953
Labels
enhancement Enhancement or improvement to existing feature or request

Comments

@linuxpi
Copy link
Collaborator

linuxpi commented Apr 18, 2023

Is your feature request related to a problem? Please describe.
Translog metadata files uploaded to remote store contain header(codec and version) and footer(checksum). This is done in TranslogTransferMetadata. While implementing the same for segment metadata files uploaded to remote store, we created new interfaced to abstract out header footer addition to input streams.

Describe the solution you'd like
Refactor Translog metadata files to use those interfaces (VersionedCodecStreamWrapper) instead of directly calling CodecUtils.

Describe alternatives you've considered
NA

Additional context
@linuxpi linuxpi added enhancement Enhancement or improvement to existing feature or request untriaged labels Apr 18, 2023
BhumikaSaini-Amazon pushed a commit to BhumikaSaini-Amazon/OpenSearch that referenced this issue Jun 7, 2023
Resolve opensearch-project#7228
fadea6f 
Signed-off-by: Bhumika Saini <sabhumik@amazon.com>
@BhumikaSaini-Amazon BhumikaSaini-Amazon mentioned this issue Jun 7, 2023
Merged
6 tasks
BhumikaSaini-Amazon pushed a commit to BhumikaSaini-Amazon/OpenSearch that referenced this issue Jun 12, 2023
Resolve opensearch-project#7228
1c7eb83 
Signed-off-by: Bhumika Saini <sabhumik@amazon.com>
@sachinpkale sachinpkale mentioned this issue Sep 6, 2023
Closed
31 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Enhancement or improvement to existing feature or request
Projects
None yet
Milestone
No milestone
2 participants
@linuxpi @minalsha