address comments

Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
opensearch-project · Jul 2, 2024 · de3fb76 · de3fb76
1 parent ddff506
commit de3fb76
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 9 deletions.
diff --git a/server/src/main/java/org/opensearch/wlm/QueryGroupThreadContextStatePropagator.java b/server/src/main/java/org/opensearch/wlm/QueryGroupThreadContextStatePropagator.java
@@ -26,13 +26,12 @@ public class QueryGroupThreadContextStatePropagator implements ThreadContextStat
      * @return the map of header and their values to be propagated across request threadContexts
      */
     @Override
+    @SuppressWarnings("removal")
     public Map<String, Object> transients(Map<String, Object> source) {
         final Map<String, Object> transientHeaders = new HashMap<>();
 
         for (String headerName : PROPAGATED_HEADERS) {
-            if (source.containsKey(headerName)) {
-                transientHeaders.put(headerName, source.get(headerName));
-            }
+            transientHeaders.compute(headerName, (k, v) -> source.get(headerName));
         }
         return transientHeaders;
     }
@@ -42,13 +41,12 @@ public Map<String, Object> transients(Map<String, Object> source) {
      * @return map of header and their values to be propagated across nodes
      */
     @Override
+    @SuppressWarnings("removal")
     public Map<String, String> headers(Map<String, Object> source) {
         final Map<String, String> propagatedHeaders = new HashMap<>();
 
         for (String headerName : PROPAGATED_HEADERS) {
-            if (source.containsKey(headerName)) {
-                propagatedHeaders.put(headerName, (String) source.get(headerName));
-            }
+            propagatedHeaders.compute(headerName, (k, v) -> (String) source.get(headerName));
         }
         return propagatedHeaders;
     }

diff --git a/server/src/main/java/org/opensearch/wlm/package-info.java b/server/src/main/java/org/opensearch/wlm/package-info.java
@@ -6,8 +6,8 @@
  * compatible open source license.
  */
 
-package org.opensearch.wlm;
-
 /**
  * This package contains workload management constructs
  */
+
+package org.opensearch.wlm;
diff --git a/...roupThreadContextStatePropagatorTest.java → ...oupThreadContextStatePropagatorTests.java b/...roupThreadContextStatePropagatorTest.java → ...oupThreadContextStatePropagatorTests.java
@@ -12,7 +12,7 @@
 
 import java.util.Map;
 
-public class QueryGroupThreadContextStatePropagatorTest extends OpenSearchTestCase {
+public class QueryGroupThreadContextStatePropagatorTests extends OpenSearchTestCase {
 
     public void testTransients() {
         QueryGroupThreadContextStatePropagator sut = new QueryGroupThreadContextStatePropagator();