[Bug] Restore timeline legacy functions and filters #825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will need to be backported into |
|
✅ DCO Check Passed 385cce0 |
|
✅ DCO Check Passed 596ce73 |
kavilla
force-pushed
the
avillk/timeline_legacy_funcs
branch
from
596ce73
to
3101fc7
Compare
While renaming we changed values from legacy naming schema to OpenSearch Dashboards naming schema. However, after realizing we impacted backwards compatibility, we restored some of the "under the hood" components backed to legacy application to allow for seemless migration. However, upon attempting to restore Timeline to work with saved objects we neglected to restore the Timeline functions. Previously users could set kibana=false to ignore filters on the dashboards being applied to their Timeline visualizations. Now, if users tried to set it then it would fail because it didn't know what that function was. This commit fixes this issue by keeping the update since we do not want to impact people who have now updated their functions and re-added the legacy functions. In this commit, I also restore the aliases for "elasticsearch" and now included "opensearch" for Timeline queries. Finally, the key was incorrect for actually accessing the filter so it never applied the filters in the default state. Issue resolved: opensearch-project#820 Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
|
✅ DCO Check Passed 3101fc7 |
kavilla
force-pushed
the
avillk/timeline_legacy_funcs
branch
from
3101fc7
to
3b191fc
Compare
|
✅ DCO Check Passed 3b191fc |
|
|
mihirsoni
approved these changes
Sep 28, 2021
Unfortunately, yeah for a specific visualization with a specific expression. |
kavilla
added a commit
to kavilla/OpenSearch-Dashboards-1
that referenced
this pull request
Sep 28, 2021
While renaming we changed values from legacy naming schema to OpenSearch Dashboards naming schema. However, after realizing we impacted backwards compatibility, we restored some of the "under the hood" components backed to legacy application to allow for seemless migration. However, upon attempting to restore Timeline to work with saved objects we neglected to restore the Timeline functions. Previously users could set kibana=false to ignore filters on the dashboards being applied to their Timeline visualizations. Now, if users tried to set it then it would fail because it didn't know what that function was. This commit fixes this issue by keeping the update since we do not want to impact people who have now updated their functions and re-added the legacy functions. In this commit, I also restore the aliases for "elasticsearch" and now included "opensearch" for Timeline queries. Finally, the key was incorrect for actually accessing the filter so it never applied the filters in the default state. Issue resolved: opensearch-project#820 Backport PR: opensearch-project#825 Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
kavilla
added a commit
to kavilla/OpenSearch-Dashboards-1
that referenced
this pull request
Sep 28, 2021
While renaming we changed values from legacy naming schema to OpenSearch Dashboards naming schema. However, after realizing we impacted backwards compatibility, we restored some of the "under the hood" components backed to legacy application to allow for seemless migration. However, upon attempting to restore Timeline to work with saved objects we neglected to restore the Timeline functions. Previously users could set kibana=false to ignore filters on the dashboards being applied to their Timeline visualizations. Now, if users tried to set it then it would fail because it didn't know what that function was. This commit fixes this issue by keeping the update since we do not want to impact people who have now updated their functions and re-added the legacy functions. In this commit, I also restore the aliases for "elasticsearch" and now included "opensearch" for Timeline queries. Finally, the key was incorrect for actually accessing the filter so it never applied the filters in the default state. Issue resolved: opensearch-project#820 Backport PR: opensearch-project#825 Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
This was referenced Sep 28, 2021
kavilla
added a commit
that referenced
this pull request
Sep 28, 2021
While renaming we changed values from legacy naming schema to OpenSearch Dashboards naming schema. However, after realizing we impacted backwards compatibility, we restored some of the "under the hood" components backed to legacy application to allow for seemless migration. However, upon attempting to restore Timeline to work with saved objects we neglected to restore the Timeline functions. Previously users could set kibana=false to ignore filters on the dashboards being applied to their Timeline visualizations. Now, if users tried to set it then it would fail because it didn't know what that function was. This commit fixes this issue by keeping the update since we do not want to impact people who have now updated their functions and re-added the legacy functions. In this commit, I also restore the aliases for "elasticsearch" and now included "opensearch" for Timeline queries. Finally, the key was incorrect for actually accessing the filter so it never applied the filters in the default state. Issue resolved: #820 Backport PR: #825 Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
kavilla
added a commit
that referenced
this pull request
Sep 28, 2021
While renaming we changed values from legacy naming schema to OpenSearch Dashboards naming schema. However, after realizing we impacted backwards compatibility, we restored some of the "under the hood" components backed to legacy application to allow for seemless migration. However, upon attempting to restore Timeline to work with saved objects we neglected to restore the Timeline functions. Previously users could set kibana=false to ignore filters on the dashboards being applied to their Timeline visualizations. Now, if users tried to set it then it would fail because it didn't know what that function was. This commit fixes this issue by keeping the update since we do not want to impact people who have now updated their functions and re-added the legacy functions. In this commit, I also restore the aliases for "elasticsearch" and now included "opensearch" for Timeline queries. Finally, the key was incorrect for actually accessing the filter so it never applied the filters in the default state. Issue resolved: #820 Backport PR: #825 Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
kavilla
added a commit
to kavilla/OpenSearch-Dashboards-1
that referenced
this pull request
Oct 11, 2021
While renaming we changed values from legacy naming schema to OpenSearch Dashboards naming schema. However, after realizing we impacted backwards compatibility, we restored some of the "under the hood" components backed to legacy application to allow for seemless migration. However, upon attempting to restore Timeline to work with saved objects we neglected to restore the Timeline functions. Previously users could set kibana=false to ignore filters on the dashboards being applied to their Timeline visualizations. Now, if users tried to set it then it would fail because it didn't know what that function was. This commit fixes this issue by keeping the update since we do not want to impact people who have now updated their functions and re-added the legacy functions. In this commit, I also restore the aliases for "elasticsearch" and now included "opensearch" for Timeline queries. Finally, the key was incorrect for actually accessing the filter so it never applied the filters in the default state. Issue resolved: opensearch-project#820 Backport: opensearch-project#825 Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
kavilla
added a commit
that referenced
this pull request
Oct 13, 2021
While renaming we changed values from legacy naming schema to OpenSearch Dashboards naming schema. However, after realizing we impacted backwards compatibility, we restored some of the "under the hood" components backed to legacy application to allow for seemless migration. However, upon attempting to restore Timeline to work with saved objects we neglected to restore the Timeline functions. Previously users could set kibana=false to ignore filters on the dashboards being applied to their Timeline visualizations. Now, if users tried to set it then it would fail because it didn't know what that function was. This commit fixes this issue by keeping the update since we do not want to impact people who have now updated their functions and re-added the legacy functions. In this commit, I also restore the aliases for "elasticsearch" and now included "opensearch" for Timeline queries. Finally, the key was incorrect for actually accessing the filter so it never applied the filters in the default state. Issue resolved: #820 Backport: #825 Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
AMoo-Miki
pushed a commit
to AMoo-Miki/OpenSearch-Dashboards
that referenced
this pull request
Feb 10, 2022
…rch-project#833) When rendering line or area charts with multiple series, we generally collect all the available X values and we automatically fill each series with missing x data points (to cover the most used case where we are rendering pre-aggregated data in Kibana). This can cause issues when we want to keep the non-consecutive nature of the line/area. This fix removes the x filling for line and area charts in the following case: non-stacked line or area chart, with continuous scale and no fit function. We apply this fix only to that specific case because: for stacked lines/area we need to clearly compute the stack of each data point on the x-axis, for categorical-ordinal scale (where a line/area chart doesn't always match with the best practice) the x-axis doesn't always describe a continuity within the data. fix opensearch-project#825 BREAKING CHANGE: when rendering non-stacked line/area charts with a continuous x scale and no fit function, the line/area between non-consecutive data points will be rendered as a continuous line/area without adding an uncertain dashed line/ semi-transparent area that connects the two, non-adjacent, points.
AMoo-Miki
pushed a commit
to AMoo-Miki/OpenSearch-Dashboards
that referenced
this pull request
Feb 10, 2022
# [23.0.0](elastic/elastic-charts@v22.0.0...v23.0.0) (2020-09-30) ### Bug Fixes * render continuous line/area between non-adjacent points ([opensearch-project#833](elastic/elastic-charts#833)) ([5222c40](elastic/elastic-charts@5222c40)), closes [opensearch-project#825](elastic/elastic-charts#825) ### Features * debug state flag added to chart status ([opensearch-project#834](elastic/elastic-charts#834)) ([f3aba25](elastic/elastic-charts@f3aba25)) * expose datum as part of GeometryValue ([opensearch-project#822](elastic/elastic-charts#822)) ([e582bd6](elastic/elastic-charts@e582bd6)) ### BREAKING CHANGES * when rendering non-stacked line/area charts with a continuous x scale and no fit function, the line/area between non-consecutive data points will be rendered as a continuous line/area without adding an uncertain dashed line/ semi-transparent area that connects the two, non-adjacent, points.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While renaming we changed values from legacy naming schema to
OpenSearch Dashboards naming schema. However, after realizing
we impacted backwards compatibility, we restored some of the
"under the hood" components backed to legacy application to
allow for seemless migration.
However, upon attempting to restore Timeline to work with saved
objects we neglected to restore the Timeline functions.
Previously users could set kibana=false to ignore filters on
the dashboards being applied to their Timeline visualizations.
Now, if users tried to set it then it would fail because it
didn't know what that function was.
This commit fixes this issue by keeping the update since we
do not want to impact people who have now updated their functions
and re-added the legacy functions.
In this commit, I also restore the aliases for "elasticsearch" and
now included "opensearch" for Timeline queries.
Finally, the key was incorrect for actually accessing the filter
so it never applied the filters in the default state.
Signed-off-by: Kawika Avilla kavilla414@gmail.com
Issues Resolved
#820
Check List