[BUG] Timeline function changed to opensearchDashboards and filters not applying if set to true #820
Labels
Comments
kavilla
added
bug
kavilla
added a commit
to kavilla/OpenSearch-Dashboards-1
that referenced
this issue
Sep 28, 2021
While renaming we changed values from legacy naming schema to OpenSearch Dashboards naming schema. However, after realizing we impacted backwards compatibility, we restored some of the "under the hood" components backed to legacy application to allow for seemless migration. However, upon attempting to restore Timeline to work with saved objects we neglected to restore the Timeline functions. Previously users could set kibana=false to ignore filters on the dashboards being applied to their Timeline visualizations. Now, if users tried to set it then it would fail because it didn't know what that function was. This commit fixes this issue by keeping the update since we do not want to impact people who have now updated their functions and re-added the legacy functions. In this commit, I also restore the aliases for "elasticsearch" and now included "opensearch" for Timeline queries. Finally, the key was incorrect for actually accessing the filter so it never applied the filters in the default state. Issue resolved: opensearch-project#820 Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
5 tasks
5 tasks
kavilla
changed the title
kavilla
added a commit
to kavilla/OpenSearch-Dashboards-1
that referenced
this issue
Sep 28, 2021
While renaming we changed values from legacy naming schema to OpenSearch Dashboards naming schema. However, after realizing we impacted backwards compatibility, we restored some of the "under the hood" components backed to legacy application to allow for seemless migration. However, upon attempting to restore Timeline to work with saved objects we neglected to restore the Timeline functions. Previously users could set kibana=false to ignore filters on the dashboards being applied to their Timeline visualizations. Now, if users tried to set it then it would fail because it didn't know what that function was. This commit fixes this issue by keeping the update since we do not want to impact people who have now updated their functions and re-added the legacy functions. In this commit, I also restore the aliases for "elasticsearch" and now included "opensearch" for Timeline queries. Finally, the key was incorrect for actually accessing the filter so it never applied the filters in the default state. Issue resolved: opensearch-project#820 Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
kavilla
added a commit
to kavilla/OpenSearch-Dashboards-1
that referenced
this issue
Sep 28, 2021
While renaming we changed values from legacy naming schema to OpenSearch Dashboards naming schema. However, after realizing we impacted backwards compatibility, we restored some of the "under the hood" components backed to legacy application to allow for seemless migration. However, upon attempting to restore Timeline to work with saved objects we neglected to restore the Timeline functions. Previously users could set kibana=false to ignore filters on the dashboards being applied to their Timeline visualizations. Now, if users tried to set it then it would fail because it didn't know what that function was. This commit fixes this issue by keeping the update since we do not want to impact people who have now updated their functions and re-added the legacy functions. In this commit, I also restore the aliases for "elasticsearch" and now included "opensearch" for Timeline queries. Finally, the key was incorrect for actually accessing the filter so it never applied the filters in the default state. Issue resolved: opensearch-project#820 Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
kavilla
added a commit
that referenced
this issue
Sep 28, 2021
While renaming we changed values from legacy naming schema to OpenSearch Dashboards naming schema. However, after realizing we impacted backwards compatibility, we restored some of the "under the hood" components backed to legacy application to allow for seemless migration. However, upon attempting to restore Timeline to work with saved objects we neglected to restore the Timeline functions. Previously users could set kibana=false to ignore filters on the dashboards being applied to their Timeline visualizations. Now, if users tried to set it then it would fail because it didn't know what that function was. This commit fixes this issue by keeping the update since we do not want to impact people who have now updated their functions and re-added the legacy functions. In this commit, I also restore the aliases for "elasticsearch" and now included "opensearch" for Timeline queries. Finally, the key was incorrect for actually accessing the filter so it never applied the filters in the default state. Issue resolved: #820 Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
kavilla
added a commit
to kavilla/OpenSearch-Dashboards-1
that referenced
this issue
Sep 28, 2021
While renaming we changed values from legacy naming schema to OpenSearch Dashboards naming schema. However, after realizing we impacted backwards compatibility, we restored some of the "under the hood" components backed to legacy application to allow for seemless migration. However, upon attempting to restore Timeline to work with saved objects we neglected to restore the Timeline functions. Previously users could set kibana=false to ignore filters on the dashboards being applied to their Timeline visualizations. Now, if users tried to set it then it would fail because it didn't know what that function was. This commit fixes this issue by keeping the update since we do not want to impact people who have now updated their functions and re-added the legacy functions. In this commit, I also restore the aliases for "elasticsearch" and now included "opensearch" for Timeline queries. Finally, the key was incorrect for actually accessing the filter so it never applied the filters in the default state. Issue resolved: opensearch-project#820 Backport PR: opensearch-project#825 Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
kavilla
added a commit
to kavilla/OpenSearch-Dashboards-1
that referenced
this issue
Sep 28, 2021
While renaming we changed values from legacy naming schema to OpenSearch Dashboards naming schema. However, after realizing we impacted backwards compatibility, we restored some of the "under the hood" components backed to legacy application to allow for seemless migration. However, upon attempting to restore Timeline to work with saved objects we neglected to restore the Timeline functions. Previously users could set kibana=false to ignore filters on the dashboards being applied to their Timeline visualizations. Now, if users tried to set it then it would fail because it didn't know what that function was. This commit fixes this issue by keeping the update since we do not want to impact people who have now updated their functions and re-added the legacy functions. In this commit, I also restore the aliases for "elasticsearch" and now included "opensearch" for Timeline queries. Finally, the key was incorrect for actually accessing the filter so it never applied the filters in the default state. Issue resolved: opensearch-project#820 Backport PR: opensearch-project#825 Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
This was referenced Sep 28, 2021
kavilla
added a commit
that referenced
this issue
Sep 28, 2021
While renaming we changed values from legacy naming schema to OpenSearch Dashboards naming schema. However, after realizing we impacted backwards compatibility, we restored some of the "under the hood" components backed to legacy application to allow for seemless migration. However, upon attempting to restore Timeline to work with saved objects we neglected to restore the Timeline functions. Previously users could set kibana=false to ignore filters on the dashboards being applied to their Timeline visualizations. Now, if users tried to set it then it would fail because it didn't know what that function was. This commit fixes this issue by keeping the update since we do not want to impact people who have now updated their functions and re-added the legacy functions. In this commit, I also restore the aliases for "elasticsearch" and now included "opensearch" for Timeline queries. Finally, the key was incorrect for actually accessing the filter so it never applied the filters in the default state. Issue resolved: #820 Backport PR: #825 Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
kavilla
added a commit
that referenced
this issue
Sep 28, 2021
While renaming we changed values from legacy naming schema to OpenSearch Dashboards naming schema. However, after realizing we impacted backwards compatibility, we restored some of the "under the hood" components backed to legacy application to allow for seemless migration. However, upon attempting to restore Timeline to work with saved objects we neglected to restore the Timeline functions. Previously users could set kibana=false to ignore filters on the dashboards being applied to their Timeline visualizations. Now, if users tried to set it then it would fail because it didn't know what that function was. This commit fixes this issue by keeping the update since we do not want to impact people who have now updated their functions and re-added the legacy functions. In this commit, I also restore the aliases for "elasticsearch" and now included "opensearch" for Timeline queries. Finally, the key was incorrect for actually accessing the filter so it never applied the filters in the default state. Issue resolved: #820 Backport PR: #825 Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
kavilla
added a commit
to kavilla/OpenSearch-Dashboards-1
that referenced
this issue
Oct 11, 2021
While renaming we changed values from legacy naming schema to OpenSearch Dashboards naming schema. However, after realizing we impacted backwards compatibility, we restored some of the "under the hood" components backed to legacy application to allow for seemless migration. However, upon attempting to restore Timeline to work with saved objects we neglected to restore the Timeline functions. Previously users could set kibana=false to ignore filters on the dashboards being applied to their Timeline visualizations. Now, if users tried to set it then it would fail because it didn't know what that function was. This commit fixes this issue by keeping the update since we do not want to impact people who have now updated their functions and re-added the legacy functions. In this commit, I also restore the aliases for "elasticsearch" and now included "opensearch" for Timeline queries. Finally, the key was incorrect for actually accessing the filter so it never applied the filters in the default state. Issue resolved: opensearch-project#820 Backport: opensearch-project#825 Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
kavilla
added a commit
that referenced
this issue
Oct 13, 2021
While renaming we changed values from legacy naming schema to OpenSearch Dashboards naming schema. However, after realizing we impacted backwards compatibility, we restored some of the "under the hood" components backed to legacy application to allow for seemless migration. However, upon attempting to restore Timeline to work with saved objects we neglected to restore the Timeline functions. Previously users could set kibana=false to ignore filters on the dashboards being applied to their Timeline visualizations. Now, if users tried to set it then it would fail because it didn't know what that function was. This commit fixes this issue by keeping the update since we do not want to impact people who have now updated their functions and re-added the legacy functions. In this commit, I also restore the aliases for "elasticsearch" and now included "opensearch" for Timeline queries. Finally, the key was incorrect for actually accessing the filter so it never applied the filters in the default state. Issue resolved: #820 Backport: #825 Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Part of the renaming strategy we changed timeline functions from
kibanatoopensearchDashboards. When hittingapi/timeline/functions, which would break existing expressions for Timeline, since function was renamed. Also the 'opensearch' and 'elasticsearch' do not work as aliases for the .es query. Finally, the key was incorrect for actually accessing the filter so it never applied the filters in the default state.For example
would not work because the
kibanafunction no longer exists.To Reproduce
Steps to reproduce the behavior:
kibana=falseTimeline request error: undefined Error: Unknown argument to es: kibanaExpected behavior
In line with our BWC tenant, existing expressions should work out of the box but there is a workaround to update the expression.
OpenSearch Version
1.x
Dashboards Version
1.x
Plugins
n/a
Screenshots
If applicable, add screenshots to help explain your problem.
Host/Environment (please complete the following information):
Additional context
Existing work around to update expression until fix is made.
The text was updated successfully, but these errors were encountered: