Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.x manual backport] BP for #7542, #7540, #7552, #7566, #7567 #7574

Merged
merged 5 commits into from
Jul 30, 2024
Merged

[2.x manual backport] BP for #7542, #7540, #7552, #7566, #7567 #7574

merged 5 commits into from
Jul 30, 2024

Commits on Jul 30, 2024

  1. [Discover 2.0] Updating fetch functions to include local cluster (ope… 

    …nsearch-project#7542)

* Update datasources fetch function to include local cluster
* Check for duplicates when fetching external datasources (in the case local cluster is added as a datasource)
* Clean up types in DataSetNavigator so items are displayed properly


---------

Signed-off-by: Sean Li <lnse@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
    @sejli @opensearch-changeset-bot @ananzh
    2 people authored and ananzh committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    1d6f0c3 View commit details
    Browse the repository at this point in the history

  2. [discover-next][bug] add max height to dataset navigator and use memo… 

    …ization (opensearch-project#7540)

* add max heigh. use memoization

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

almost working pretty nicely

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

a  little bit better

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

its ok

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* update mock

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* update another mock

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* fix mock for extension

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* rebase fixes

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* update script

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* fix initial load

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

---------

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
    @kavilla @ananzh
    kavilla authored and ananzh committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    4a7458a View commit details
    Browse the repository at this point in the history

  3. Fix query assist for query editor (opensearch-project#7552) 

    After the following PRs:  opensearch-project#7492, opensearch-project#7546, opensearch-project#7540

this commit added skip(1) back to dataset manager observable: fef6156, we need to revert changes done in
fix(query assist): update reading data source id from dataset manager opensearch-project#7464 (comment)

    revert dataset manager observable usage in query assist to support skip(1)
    revert dataset manager tests

[Discover Next] Fixes Discover styles opensearch-project#7546 removed query editor header div, this PR adds it back to enable query editor extensions

Signed-off-by: Joshua Li <joshuali925@gmail.com>
    @joshuali925 @ananzh
    joshuali925 authored and ananzh committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    f637648 View commit details
    Browse the repository at this point in the history

  4. [Discover next] Fixes dataset navigator menu styling & search error t… 

    …oast (opensearch-project#7566)

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
    @ashwin-pc @ananzh
    ashwin-pc authored and ananzh committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    ea4071c View commit details
    Browse the repository at this point in the history

  5. [Discover 2.0] Loading fix for databases (opensearch-project#7567) 

    * add back in useeffect for loading databases

Signed-off-by: Sean Li <lnse@amazon.com>

* Changeset file for PR opensearch-project#7567 created/updated

---------

Signed-off-by: Sean Li <lnse@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
    @sejli @opensearch-changeset-bot @ananzh
    2 people authored and ananzh committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    63917ef View commit details
    Browse the repository at this point in the history