Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [Discover-next] query editor and UI settings toggle #7028

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

@opensearch-trigger-bot opensearch-trigger-bot bot commented Jun 14, 2024

Backport a4aa682 from #7001.

Changelog

  • skip

* [Discover-next] query editor and UI settings toggle

Adds new query editor in replacement of query string input.

Utilizing:
```
data.enhancements.enabled: true
```

And enabling the Advanced Setting: `query:enhancements:enabled`

Also, cleans up the toggling since it is now two different components.

Related issue:
#6067

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* Remove commented out code

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

---------

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
(cherry picked from commit a4aa682)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

Copy link

codecov bot commented Jun 14, 2024

Codecov Report

Attention: Patch coverage is 55.86207% with 64 lines in your changes missing coverage. Please review.

Project coverage is 67.55%. Comparing base (7674d3c) to head (ea7f4c4).
Report is 1 commits behind head on 2.x.

Files Patch % Lines
src/plugins/data/public/ui/settings/settings.ts 33.33% 16 Missing and 2 partials ⚠️
...c/plugins/data/public/ui/search_bar/search_bar.tsx 47.61% 6 Missing and 5 partials ⚠️
.../data_explorer/public/components/sidebar/index.tsx 52.38% 8 Missing and 2 partials ⚠️
.../data/public/ui/query_editor/language_selector.tsx 59.09% 8 Missing and 1 partial ⚠️
src/plugins/data/public/ui/ui_service.ts 0.00% 4 Missing ⚠️
...public/ui/query_string_input/language_switcher.tsx 78.57% 3 Missing ⚠️
...ns/data/public/ui/search_bar/create_search_bar.tsx 0.00% 3 Missing ⚠️
src/plugins/data/public/ui/query_editor/index.tsx 71.42% 2 Missing ⚠️
src/plugins/data/public/plugin.ts 0.00% 1 Missing ⚠️
src/plugins/data/public/ui/mocks.ts 0.00% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##              2.x    #7028      +/-   ##
==========================================
- Coverage   67.56%   67.55%   -0.01%     
==========================================
  Files        3441     3443       +2     
  Lines       67805    67854      +49     
  Branches    11017    11017              
==========================================
+ Hits        45810    45842      +32     
- Misses      19333    19353      +20     
+ Partials     2662     2659       -3     
Flag Coverage Δ
Linux_1 33.09% <25.00%> (-0.01%) ⬇️
Linux_2 55.23% <ø> (ø)
Linux_3 45.23% <55.55%> (+0.02%) ⬆️
Linux_4 35.03% <27.02%> (-0.01%) ⬇️
Windows_1 33.11% <25.00%> (-0.01%) ⬇️
Windows_2 55.18% <ø> (ø)
Windows_3 45.25% <55.55%> (+0.02%) ⬆️
Windows_4 35.03% <27.02%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kavilla kavilla added Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry and removed failed changeset labels Jun 15, 2024
@kavilla kavilla merged commit 727ec51 into 2.x Jun 20, 2024
69 of 72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut Skip the changelog verification check on backports discover for discover reinvent discover-next distinguished-contributor Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants