Add Scripted Field Support in Vis Builder #6974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opensearch-changeset-bot bot
added a commit
to LDrago27/OpenSearch-Dashboards
that referenced
this pull request
Jun 7, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6974 +/- ##
==========================================
+ Coverage 67.43% 67.44% +0.01%
==========================================
Files 3444 3442 -2
Lines 67819 67816 -3
Branches 11034 11027 -7
==========================================
+ Hits 45733 45740 +7
+ Misses 19420 19409 -11
- Partials 2666 2667 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
virajsanghvi
reviewed
Jun 8, 2024
src/plugins/vis_builder/public/application/components/data_tab/utils/get_available_fields.ts
Show resolved
Hide resolved
Signed-off-by: Suchit Sahoo <suchsah@amazon.com>
LDrago27
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi and
mengweieric
as code owners
virajsanghvi
approved these changes
Jun 11, 2024
|
@LDrago27 Can you add a test for this? |
@ashwin-pc I have added unit tests to validate this change. |
ananzh
approved these changes
Jun 11, 2024
manasvinibs
approved these changes
Jun 11, 2024
ashwin-pc
approved these changes
Jun 12, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 12, 2024
Signed-off-by: Suchit Sahoo <suchsah@amazon.com> (cherry picked from commit e74ed2c) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
74 tasks
abbyhu2000
pushed a commit
that referenced
this pull request
Jul 22, 2024
(cherry picked from commit e74ed2c) Signed-off-by: Suchit Sahoo <suchsah@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 23, 2024
(cherry picked from commit e74ed2c) Signed-off-by: Suchit Sahoo <suchsah@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> (cherry picked from commit a0eea7d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add Scripted Field Support in Vis Builder.
Screenshot
Video.mp4
Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integration