Discover Flint datasource selector implementation #6833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulstn
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi and
mengweieric
as code owners
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/discover-next #6833 +/- ##
=========================================================
- Coverage 67.05% 67.04% -0.01%
=========================================================
Files 3451 3451
Lines 68216 68208 -8
Branches 11140 11139 -1
=========================================================
- Hits 45740 45731 -9
- Misses 19856 19857 +1
Partials 2620 2620
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kavilla
reviewed
May 24, 2024
src/plugins/discover/public/application/helpers/get_data_source_fetch_strategy.ts
Outdated
Show resolved
Hide resolved
kavilla
reviewed
May 24, 2024
src/plugins/discover/public/application/helpers/get_data_source_fetch_strategy.ts
Outdated
Show resolved
Hide resolved
kavilla
reviewed
May 24, 2024
kavilla
reviewed
May 24, 2024
paulstn
force-pushed
the
discover-flint-datasource-selector
branch
2 times, most recently
from
ab40e0e
to
a155fe5
Compare
kavilla
reviewed
Jun 4, 2024
kavilla
reviewed
Jun 4, 2024
src/plugins/data/public/data_sources/datasource_selector/types.ts
Outdated
Show resolved
Hide resolved
| @@ -51,6 +51,7 @@ export interface IDataSourceSettings<T extends IDataSourceMetadata = IDataSource | |||
| id: string; | |||
| type: string; | |||
| name: string; | |||
| connectionType: 'os' | 'flint'; | |||
| metadata: T; | |||
There was a problem hiding this comment.
do we know what is apart of the metadata field?
|
Hi @paulstn , is this PR targeting 2.15 or 2.16? |
kavilla
force-pushed
the
feature/discover-next
branch
from
8bb3b5d
to
016e0f2
Compare
2.15 |
Signed-off-by: Paul Sebastian <paulstn@amazon.com>
Signed-off-by: Paul Sebastian <paulstn@amazon.com>
Signed-off-by: Paul Sebastian <paulstn@amazon.com>
…ch params Signed-off-by: Paul Sebastian <paulstn@amazon.com>
Signed-off-by: Paul Sebastian <paulstn@amazon.com>
Signed-off-by: Paul Sebastian <paulstn@amazon.com>
Signed-off-by: Paul Sebastian <paulstn@amazon.com>
Signed-off-by: Paul Sebastian <paulstn@amazon.com>
Signed-off-by: Paul Sebastian <paulstn@amazon.com>
paulstn
force-pushed
the
discover-flint-datasource-selector
branch
from
e095c56
to
09e1b9e
Compare
paulstn
commented
Jun 5, 2024
| @@ -72,7 +72,7 @@ export const useSearch = (services: DiscoverViewServices) => { | |||
| const [savedSearch, setSavedSearch] = useState<SavedSearch | undefined>(undefined); | |||
| const { savedSearch: savedSearchId, sort, interval } = useSelector((state) => state.discover); | |||
| const { data, filterManager, getSavedSearchById, core, toastNotifications, chrome } = services; | |||
| const indexPattern = useIndexPattern(services); | |||
| const { indexPattern, dataSource } = useIndexPattern(services); | |||
There was a problem hiding this comment.
@kavilla I was using the index pattern hook to pass along the data source information as a temporary solution, should I create another hook for datasource or generalize this index pattern hook?
|
@paulstn is the PR ready for review? |
Signed-off-by: Paul Sebastian <paulstn@amazon.com>
Signed-off-by: Paul Sebastian <paulstn@amazon.com>
kavilla
reviewed
Jun 6, 2024
| export const S3_GLUE_DATA_SOURCE_DISPLAY_NAME = 'Amazon S3'; | ||
| export const S3_GLUE_DATA_SOURCE_TYPE = 's3glue'; | ||
| export const DEFAULT_DATA_SOURCE_TYPE = 'DEFAULT_INDEX_PATTERNS'; | ||
| export const DEFAULT_DATA_SOURCE_TYPE = 'default'; |
There was a problem hiding this comment.
does this have functional purposes outside of redirecting?
kavilla
approved these changes
Jun 6, 2024
kavilla
merged commit 7eeecf9
into
opensearch-project:feature/discover-next
40 of 66 checks passed
joshuali925
added a commit
to joshuali925/OpenSearch-Dashboards
that referenced
this pull request
Jun 14, 2024
SearchBar extensions depend on the currently selected dataSource, which depends on opensearch-project#6833 to be ported to main Signed-off-by: Joshua Li <joshuali925@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
Screenshot
Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integration