[Bug] fix timeline icon in Visualize list #659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Icon was not loading in the Visualize list because it was referencing a non-existant icon. Other parts of the code loads the icon correctly, so updated the icon to an existing icon. Issues resolved: opensearch-project#658 Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
|
✅ DCO Check Passed e639ecf |
|
|
|
|
tmarkley
approved these changes
Jul 22, 2021
|
Also, is it possible to add a test for this? |
kavilla
added a commit
to kavilla/OpenSearch-Dashboards-1
that referenced
this pull request
Jul 26, 2021
Icon was not loading in the Visualize list because it was referencing a non-existant icon. Other parts of the code loads the icon correctly, so updated the icon to an existing icon. Issues resolved: opensearch-project#658 Backport PR: opensearch-project#659 Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Icon was not loading in the Visualize list because it was
referencing a non-existant icon. Other parts of the code
loads the icon correctly, so updated the icon to an existing
icon.
Signed-off-by: Kawika Avilla kavilla414@gmail.com
Issues Resolved
#658
Check List