Hide datasource and settings menu in dashboard management when in workspace #6455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raintygao
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT and
xinruiba
as code owners
raintygao
changed the title
ruanyl
reviewed
Apr 15, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6455 +/- ##
===========================================
+ Coverage 32.93% 55.61% +22.67%
===========================================
Files 2260 1200 -1060
Lines 45769 24271 -21498
Branches 7200 4094 -3106
===========================================
- Hits 15075 13498 -1577
+ Misses 29984 10128 -19856
+ Partials 710 645 -65
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Hailong-am
approved these changes
Apr 16, 2024
… workspace Signed-off-by: tygao <tygao@amazon.com>
Signed-off-by: tygao <tygao@amazon.com>
Co-authored-by: Yulong Ruan <ruanyu1@gmail.com> Signed-off-by: tygao <tygao@amazon.com>
raintygao
force-pushed
the
feat-hide-menus
branch
from
59f62fa
to
8d074c3
Compare
SuZhou-Joe
approved these changes
Apr 17, 2024
ruanyl
approved these changes
Apr 17, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 22, 2024
…kspace (#6455) * hide datasource and settings menu when workspace enabled and entering workspace Signed-off-by: tygao <tygao@amazon.com> * doc: update changelog Signed-off-by: tygao <tygao@amazon.com> * update comments Co-authored-by: Yulong Ruan <ruanyu1@gmail.com> Signed-off-by: tygao <tygao@amazon.com> --------- Signed-off-by: tygao <tygao@amazon.com> Co-authored-by: Yulong Ruan <ruanyu1@gmail.com> (cherry picked from commit 7a46475) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
SuZhou-Joe
pushed a commit
that referenced
this pull request
Apr 22, 2024
…kspace (#6455) (#6579) * hide datasource and settings menu when workspace enabled and entering workspace Signed-off-by: tygao <tygao@amazon.com> * doc: update changelog Signed-off-by: tygao <tygao@amazon.com> * update comments Co-authored-by: Yulong Ruan <ruanyu1@gmail.com> Signed-off-by: tygao <tygao@amazon.com> --------- Signed-off-by: tygao <tygao@amazon.com> Co-authored-by: Yulong Ruan <ruanyu1@gmail.com> (cherry picked from commit 7a46475) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hide datasource and settings menu in dashboard management when in workspace
Issues Resolved
#6453
Screenshot
In workspace
Not in workspace
Testing the changes
When set workspace feature enabled in YML and entering workspace, the data source and advanced settings menu will be hidden. These two menus will show after exiting workspace.
Check List
yarn test:jestyarn test:jest_integration