Add a few dev guide based on observations #6449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lu Yu <nluyu@amazon.com>
Signed-off-by: Lu Yu <nluyu@amazon.com>
BionIT
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl and
xinruiba
as code owners
seraphjiang
reviewed
Apr 15, 2024
| continued lines are indented.'; | ||
| ``` | ||
|
|
||
| #### Avoid using `@ts-ignore` |
There was a problem hiding this comment.
+1 we should not take shortcut to ignore the warning or error
seraphjiang
approved these changes
Apr 15, 2024
There was a problem hiding this comment.
It is always good to learn how to write elegant code, thanks @BionIT
ZilongX
approved these changes
Apr 15, 2024
zhongnansu
approved these changes
Apr 16, 2024
|
could you update the change log? |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 16, 2024
* add a few developer guides based on observations Signed-off-by: Lu Yu <nluyu@amazon.com> * add more info Signed-off-by: Lu Yu <nluyu@amazon.com> --------- Signed-off-by: Lu Yu <nluyu@amazon.com> (cherry picked from commit 3d91b94) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
77 tasks
BionIT
pushed a commit
that referenced
this pull request
Apr 16, 2024
* add a few developer guides based on observations * add more info --------- (cherry picked from commit 3d91b94) Signed-off-by: Lu Yu <nluyu@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change adds a few dev guides based on observations when reviewing PRs, and the intent is to use current guide to illustrate the best practice and a reference for contributors.
Check List
yarn test:jestyarn test:jest_integration