Add dev guide for pull request #6448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lu Yu <nluyu@amazon.com>
BionIT
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl and
xinruiba
as code owners
seraphjiang
reviewed
Apr 15, 2024
|
|
||
| ## Submit pull request | ||
| ### Before submit a pull request | ||
| First-time contributors should head to the [contributing guide](https://github.com/opensearch-project/OpenSearch-Dashboards/blob/main/CONTRIBUTING.md) to get started. |
There was a problem hiding this comment.
Even for experience developer is it worth to read it again. Maybe we could add to PR check list.
seraphjiang
approved these changes
Apr 15, 2024
seraphjiang
reviewed
Apr 15, 2024
| If you don't know how to test a feature, please ask! Pull requests lacking sufficient testing coverage may be subject to delays in review or rejection until adequate tests are provided. | ||
|
|
||
| The repository has automated test workflows, and contributors submitting pull requests are required to check the failed test workflows and fix the tests related to their code change. If flaky test is identified, please ask a maintainer to retry the workflow. | ||
|
|
There was a problem hiding this comment.
should we add a link to https://github.com/opensearch-project/OpenSearch-Dashboards/blob/main/CONTRIBUTING.md#review-process
and also mention a little bit about backport process and responsibility
ZilongX
approved these changes
Apr 15, 2024
zhongnansu
approved these changes
Apr 16, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 16, 2024
Signed-off-by: Lu Yu <nluyu@amazon.com> (cherry picked from commit ce85706) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
77 tasks
BionIT
pushed a commit
that referenced
this pull request
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change adds a section in the dev guides about pull request, and it is based on observations when reviewing PRs, and the intent is to use current guide to illustrate the best practice and a reference to help improve the pull request quality. It might not capture everything but can be a good start.
Check List
yarn test:jestyarn test:jest_integration