[Multiple Datasource] Add Empty state no_data_source #6445
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>
Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>
Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>
Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6445 +/- ##
==========================================
- Coverage 45.18% 45.17% -0.01%
==========================================
Files 1656 1657 +1
Lines 33591 33608 +17
Branches 6385 6393 +8
==========================================
+ Hits 15177 15184 +7
- Misses 17244 17246 +2
- Partials 1170 1178 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>
yujin-emma
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT and
xinruiba
as code owners
BionIT
reviewed
Apr 15, 2024
src/plugins/data_source_management/public/components/no_data_source/no_data_source.tsx
Outdated
Show resolved
Hide resolved
src/plugins/data_source_management/public/components/data_source_menu/types.ts
Outdated
Show resolved
Hide resolved
src/plugins/data_source_management/public/components/data_source_menu/data_source_menu.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>
Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>
Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>
Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>
Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>
Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>
Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>
yujin-emma
commented
Apr 16, 2024
examples/multiple_data_source_examples/public/components/home.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>
Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>
Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>
BionIT
reviewed
Apr 16, 2024
| @@ -63,6 +66,11 @@ export class DataSourceAggregatedView extends React.Component< | |||
| this._isMounted = true; | |||
| getDataSourcesWithFields(this.props.savedObjectsClient, ['id', 'title', 'auth.type']) | |||
| .then((fetchedDataSources) => { | |||
| if (fetchedDataSources?.length === 0) { | |||
| this.setState({ | |||
| showEmptyState: true, | |||
There was a problem hiding this comment.
is it possible that we have local cluster?
There was a problem hiding this comment.
is it possible that there is data source but filtered out?
| @@ -153,4 +153,16 @@ describe('DataSourceMenu', () => { | |||
| ); | |||
| expect(container).toMatchSnapshot(); | |||
| }); | |||
|
|
|||
| it('should render no data source', () => { | |||
| component = shallow( | |||
There was a problem hiding this comment.
let's not expose this component from data source menu
src/plugins/data_source_management/public/components/data_source_menu/data_source_menu.tsx
Outdated
Show resolved
Hide resolved
...e_management/public/components/data_source_multi_selectable/data_source_multi_selectable.tsx
Outdated
Show resolved
Hide resolved
...s/data_source_management/public/components/data_source_selectable/data_source_selectable.tsx
Show resolved
Hide resolved
Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>
Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>
Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>
Signed-off-by: Yu Jin <112784385+yujin-emma@users.noreply.github.com>
Signed-off-by: Yu Jin <112784385+yujin-emma@users.noreply.github.com>
|
Can you close this PR if not relevant any more @yujin-emma? |
+1, I see the original issue is closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add the empty state component for multiple data source, and add it on examples.
When enable multiple datasource feature, this empty state will display when there is no remote data source and hide the local cluster.
Issues Resolved
#6420
Screenshot
when there is no remote data source but do not hide local cluster
when there is no remote data source but do hide local cluster
Testing the changes
Check List
yarn test:jestyarn test:jest_integration