[Multiple Datasource] Use data source filter function before rendering #6175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lu Yu <nluyu@amazon.com>
BionIT
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
BSFishy,
curq,
bandinib-amzn,
SuZhou-Joe and
ruanyl
as code owners
BionIT
changed the title
Signed-off-by: Lu Yu <nluyu@amazon.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6175 +/- ##
==========================================
- Coverage 67.25% 67.25% -0.01%
==========================================
Files 3345 3345
Lines 64840 64835 -5
Branches 10435 10432 -3
==========================================
- Hits 43606 43602 -4
Misses 18690 18690
+ Partials 2544 2543 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ruanyl
previously approved these changes
Mar 18, 2024
xinruiba
approved these changes
Mar 18, 2024
Signed-off-by: Lu Yu <nluyu@amazon.com>
xinruiba
approved these changes
Mar 19, 2024
ZilongX
approved these changes
Mar 19, 2024
|
LGTM, picked up latest main branch and now rerun all checks |
| @@ -119,6 +99,16 @@ export class DataSourceSelector extends React.Component< | |||
| this.props.placeholderText === undefined | |||
| ? 'Select a data source' | |||
| : this.props.placeholderText; | |||
|
|
|||
| const dataSources = this.props.dataSourceFilter | |||
There was a problem hiding this comment.
Do we have UT to cover this changes? Thanks
There was a problem hiding this comment.
+1. Approved but I'm wondering if we need UT for this change.
There was a problem hiding this comment.
yes, we use the same unit test for the filtering which was added when the datasource filter was introduced https://github.com/opensearch-project/OpenSearch-Dashboards/blob/main/src/plugins/data_source_management/public/components/data_source_selector/data_source_selector.test.tsx#L137
bandinib-amzn
approved these changes
Mar 19, 2024
Flyingliuhub
approved these changes
Mar 19, 2024
77 tasks
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 25, 2024
#6175) * use filter function before rendering Signed-off-by: Lu Yu <nluyu@amazon.com> * add change log Signed-off-by: Lu Yu <nluyu@amazon.com> --------- Signed-off-by: Lu Yu <nluyu@amazon.com> Co-authored-by: ZilongX <99905560+ZilongX@users.noreply.github.com> (cherry picked from commit 8975381) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
BionIT
pushed a commit
that referenced
this pull request
Mar 25, 2024
#6175) (#6265) * use filter function before rendering Signed-off-by: Lu Yu <nluyu@amazon.com> * add change log Signed-off-by: Lu Yu <nluyu@amazon.com> --------- Signed-off-by: Lu Yu <nluyu@amazon.com> Co-authored-by: ZilongX <99905560+ZilongX@users.noreply.github.com> (cherry picked from commit 8975381) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change will store all data sources fetched during initial load, then apply the datasource filter function before rendering so that it can filter based on changes in the filter function.
Issues Resolved
Fixes #6174
Screenshot
filterbeforerender.mp4
Testing the changes
The following steps were performed in the recording:
Check List
yarn test:jestyarn test:jest_integration