[Multiple DataSource] DataSource creation and edition page improvement to better support registered auth types #6122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…itDataSource pages Signed-off-by: Xinrui Bai <xinruiba@amazon.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6122 +/- ##
=======================================
Coverage 67.17% 67.18%
=======================================
Files 3328 3328
Lines 64448 64461 +13
Branches 10376 10376
=======================================
+ Hits 43295 43306 +11
- Misses 18621 18622 +1
- Partials 2532 2533 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…ge and edit page Signed-off-by: Xinrui Bai <xinruiba@amazon.com>
Signed-off-by: Xinrui Bai <xinruiba@amazon.com>
Signed-off-by: Xinrui Bai <xinruiba@amazon.com>
xinruiba
changed the title
xinruiba
changed the title
Signed-off-by: Xinrui Bai <xinruiba@amazon.com>
xinruiba
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
kristenTian,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
BSFishy,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl and
BionIT
as code owners
yujin-emma
approved these changes
Mar 13, 2024
ruanyl
reviewed
Mar 13, 2024
...management/public/components/edit_data_source/components/edit_form/edit_data_source_form.tsx
Show resolved
Hide resolved
...management/public/components/edit_data_source/components/edit_form/edit_data_source_form.tsx
Outdated
Show resolved
Hide resolved
...management/public/components/edit_data_source/components/edit_form/edit_data_source_form.tsx
Show resolved
Hide resolved
Signed-off-by: Xinrui Bai <xinruiba@amazon.com>
bandinib-amzn
previously approved these changes
Mar 13, 2024
| @@ -380,5 +380,71 @@ describe('DataSourceManagement: Utils.ts', () => { | |||
|
|
|||
| expect(deepEqual(registedAuthTypeCredentials, expectExtractedAuthCredentials)); | |||
| }); | |||
|
|
|||
| test('Should inherit value from registered field when credentail state not have registered field', () => { | |||
There was a problem hiding this comment.
Typo: credentail. Actually, there are only 8 files referenced by crendentialFormField. Can you please fix crendentialFormField in this PR, and then fix #6122 (comment) (31 files referenced)?
There was a problem hiding this comment.
Sure, thanks for the comment.
Fixing.
There was a problem hiding this comment.
crendentialFormField typo resolved, thanks.
Signed-off-by: Xinrui Bai <xinruiba@amazon.com>
Signed-off-by: Xinrui Bai <xinruiba@amazon.com>
Flyingliuhub
approved these changes
Mar 14, 2024
bandinib-amzn
approved these changes
Mar 14, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 14, 2024
…t to better support registered auth types (#6122) * [Token Exchange Unification] State update for createDataSource and editDataSource pages Signed-off-by: Xinrui Bai <xinruiba@amazon.com> * [Token Exchange Unification] rectify state for dataSource creation page and edit page Signed-off-by: Xinrui Bai <xinruiba@amazon.com> * [UT] Add more test cases for util functions Signed-off-by: Xinrui Bai <xinruiba@amazon.com> * [Token Exchange Unification] Update dataSource bottom banner control Signed-off-by: Xinrui Bai <xinruiba@amazon.com> * Update changefile.md Signed-off-by: Xinrui Bai <xinruiba@amazon.com> * Add comments Signed-off-by: Xinrui Bai <xinruiba@amazon.com> * Code review change, fix typo Signed-off-by: Xinrui Bai <xinruiba@amazon.com> * Resolve comments, update typo in test cases Signed-off-by: Xinrui Bai <xinruiba@amazon.com> --------- Signed-off-by: Xinrui Bai <xinruiba@amazon.com> (cherry picked from commit 31e8481) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
Flyingliuhub
pushed a commit
that referenced
this pull request
Mar 14, 2024
…t to better support registered auth types (#6122) (#6145) * [Token Exchange Unification] State update for createDataSource and editDataSource pages Signed-off-by: Xinrui Bai <xinruiba@amazon.com> * [Token Exchange Unification] rectify state for dataSource creation page and edit page Signed-off-by: Xinrui Bai <xinruiba@amazon.com> * [UT] Add more test cases for util functions Signed-off-by: Xinrui Bai <xinruiba@amazon.com> * [Token Exchange Unification] Update dataSource bottom banner control Signed-off-by: Xinrui Bai <xinruiba@amazon.com> * Update changefile.md Signed-off-by: Xinrui Bai <xinruiba@amazon.com> * Add comments Signed-off-by: Xinrui Bai <xinruiba@amazon.com> * Code review change, fix typo Signed-off-by: Xinrui Bai <xinruiba@amazon.com> * Resolve comments, update typo in test cases Signed-off-by: Xinrui Bai <xinruiba@amazon.com> --------- Signed-off-by: Xinrui Bai <xinruiba@amazon.com> (cherry picked from commit 31e8481) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is the PR to improve state handle for "CreateDataSource" and "EditDataSource" pages. With this change registered auth type with be better supported in editDataSource page by showing initial credential info in the edit page
Issues Resolved
Partially fixes #5692, #5838
Screenshot
CreateDataSourceWithTokenExchange.mov
EditTestingForTokenExchange.mov
Testing the changes
For the first video, we do following steps to test dataSource creation:
For the second video, we do following steps to test dataSource edition:
Check List
yarn test:jestyarn test:jest_integration