Fix Test connection for data source #5958
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bandini Bhopi <bandinib@amazon.com>
bandinib-amzn
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
kristenTian,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
BSFishy,
curq and
SuZhou-Joe
as code owners
bandinib-amzn
added
backport 2.x
multiple datasource
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5958 +/- ##
=======================================
Coverage 67.00% 67.00%
=======================================
Files 3307 3307
Lines 63614 63614
Branches 10163 10163
=======================================
+ Hits 42625 42627 +2
+ Misses 18519 18518 -1
+ Partials 2470 2469 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
xinruiba
approved these changes
Feb 26, 2024
Flyingliuhub
approved these changes
Feb 27, 2024
|
@bandinib-amzn do we need to backport 2.12 branch as well? |
|
PR #5944 for the same issue has been raised 3 days before. Closing this as duplicate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Due to missing
customApiRegistryparameter, Test connection was broken in data source. This PR fixes that issue.Issues Resolved
#5924
Screenshot
Testing the changes
Check List
yarn test:jestyarn test:jest_integration