Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Test] Fix console error in search_service.test.ts  #595

Merged
merged 1 commit into from
Jul 26, 2021
Merged

[Test] Fix console error in search_service.test.ts  #595

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/plugins/data/server/search/search_service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ export class SearchService implements Plugin<ISearchSetup, ISearchStart> {
.pipe(first())
.toPromise()
.then((value) => {
if (value.search.aggs.shardDelay.enabled) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this always undefined? if so it's not an error right otherwise could this conditional be completely removed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with you that if value.search.aggs.shardDelay.enabled is always undefined, then removed this completely. But the question is how can we know it is always undefined?

src/plugins/data/server/search/search_service.ts does have value tested as null therefore value.search.aggs is undefined. I am not sure whether in real application usage, value or value.search will always be undefined or not, so I just add conditional check for each one. I think that is more logically restrict. What do you think?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine but almost would prefer to have a TODO here to figure if this is always undefined then merge in your current fix to unblock us.

if (value?.search?.aggs?.shardDelay?.enabled) {
aggs.types.registerBucket(SHARD_DELAY_AGG_NAME, getShardDelayBucketAgg);
registerFunction(aggShardDelay);
}
Expand Down