Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove empty space when resize datagrid table in Discover and Allow saving column width in both Discover and Dashboards Embeddable #5883

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ananzh
Copy link
Member

@ananzh ananzh commented Feb 16, 2024

Description

Issues Resolved

#5671
#5726

Screenshot

rm-empty-space-savable-width.mov

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@ananzh ananzh changed the title allow column to proper resize Remove empty space when resize datagrid table in Discover and allow saving column width in Discover and Dashboards Embeddable Feb 16, 2024
@ananzh ananzh changed the title Remove empty space when resize datagrid table in Discover and allow saving column width in Discover and Dashboards Embeddable Remove empty space when resize datagrid table in Discover and Allow saving column width in both Discover and Dashboards Embeddable Feb 16, 2024
Copy link

codecov bot commented Feb 16, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 67.34%. Comparing base (902e216) to head (6a22b71).
Report is 113 commits behind head on main.

Files Patch % Lines
...lication/utils/state_management/discover_slice.tsx 50.00% 1 Missing and 1 partial ⚠️
...n/components/data_grid/data_grid_table_columns.tsx 80.00% 1 Missing ⚠️
src/plugins/discover/public/migrate_state.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5883      +/-   ##
==========================================
- Coverage   67.34%   67.34%   -0.01%     
==========================================
  Files        3352     3352              
  Lines       65080    65088       +8     
  Branches    10485    10488       +3     
==========================================
+ Hits        43829    43834       +5     
- Misses      18699    18701       +2     
- Partials     2552     2553       +1     
Flag Coverage Δ
Linux_1 31.82% <0.00%> (-0.01%) ⬇️
Linux_2 55.57% <ø> (ø)
Linux_3 44.75% <66.66%> (+<0.01%) ⬆️
Linux_4 35.03% <ø> (ø)
Windows_1 31.84% <0.00%> (-0.01%) ⬇️
Windows_2 55.53% <ø> (ø)
Windows_3 44.75% <66.66%> (+<0.01%) ⬆️
Windows_4 35.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ananzh ananzh added the bug Something isn't working label Mar 21, 2024
Signed-off-by: Anan Z <ananzh@amazon.com>
@ananzh ananzh removed the enhancement New feature or request label Mar 22, 2024
Copy link
Member

@ashwin-pc ashwin-pc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM. Thanks for adding the test :)

@ananzh ananzh added v2.14.0 and removed v2.13.0 labels Mar 22, 2024
@ananzh
Copy link
Member Author

ananzh commented Mar 22, 2024

We think add this will slow the column resize and might choose a different way to resolve the issue. As synced up with @ashwin-pc, we will put it in 2.14 release.

@AMoo-Miki AMoo-Miki marked this pull request as draft March 26, 2024 17:46
@kavilla kavilla added v2.15.0 and removed v2.14.0 labels May 2, 2024
@kavilla
Copy link
Member

kavilla commented May 2, 2024

@ananzh will remove the 2.14 label as this in draft still. And have added the 2.15 label or if it needs to be closed feel free to do so.

@BionIT
Copy link
Collaborator

BionIT commented Jun 5, 2024

Hi @ananzh , is this PR targeting 2.15?

@ananzh ananzh removed the v2.15.0 label Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working discover for discover reinvent distinguished-contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants