[Test] Enable unit test suite: render_opt_in_banner.test.ts #505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ch-project#503) All the unit tests related to unused telemetry are temporarily skipped after the fork. Unit tests of the disabled telemetry functions should also be modified correspondingly. To build a clean unit test, we decide to modify and enable all the working unit tests. This PR modifies and enables render_opt_in_banner.test.ts. Signed-off-by: Anan Zhuang <ananzh@amazon.com>
26 tasks
|
✅ DCO Check Passed 2dcd565 |
ananzh
changed the title
tmarkley
approved these changes
Jun 21, 2021
kavilla
approved these changes
Jun 23, 2021
kavilla
pushed a commit
that referenced
this pull request
Jun 26, 2021
) All the unit tests related to unused telemetry are temporarily skipped after the fork. Unit tests of the disabled telemetry functions should also be modified correspondingly. To build a clean unit test, we decide to modify and enable all the working unit tests. This PR modifies and enables render_opt_in_banner.test.ts. Signed-off-by: Anan Zhuang <ananzh@amazon.com>
kavilla
pushed a commit
that referenced
this pull request
Jun 26, 2021
) All the unit tests related to unused telemetry are temporarily skipped after the fork. Unit tests of the disabled telemetry functions should also be modified correspondingly. To build a clean unit test, we decide to modify and enable all the working unit tests. This PR modifies and enables render_opt_in_banner.test.ts. Signed-off-by: Anan Zhuang <ananzh@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
All the unit tests related to unused telemetry are temporarily
skipped after the fork. Unit tests of the disabled telemetry
functions should also be modified correspondingly. To build
a clean unit test, we decide to modify and enable all the
working unit tests. This PR modifies and enables
render_opt_in_banner.test.ts.
Signed-off-by: Anan Zhuang ananzh@amazon.com
Issues Resolved
#503
Test results
unit test for render_opt_in_banner.test.ts
Overall test result:
Check List