Renaming dashboard, data plugin folder to kebab-case #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ DCO Check Passed e01a335 |
kavilla
requested changes
Jun 3, 2021
Signed-off-by: Vacha Shah <vachshah@amazon.com>
VachaShah
force-pushed
the
update_dashboard_data_plugin_to_kebab_case
branch
from
e01a335
to
cd2aae7
Compare
|
✅ DCO Check Passed cd2aae7 |
No problem! Rebased the PR. |
|
Will be verifying PRs into a branch into my fork repo. Link to PR: kavilla#4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vacha Shah vachshah@amazon.com
Description
This PR updates the folder names for pre-installed plugin
dashboardanddatain src/plugins to kebab-case to maintain consistency as described in Issue #322.Testing
The following commands succeeded:
yarn test:jestTEST_OPENSEARCH_FROM=/path/to/extracted/build/artifact yarn test:jest_integrationIssues Resolved
Part 2 of #322.
Note: This PR is one of many PRs for renaming the folder names of the pre-installed plugins.
Check List