Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Dashboard Lists Integration #3749

Merged
merged 1 commit into from
Apr 4, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport d2bd318 from #3090.

* Dashboard-List Integration
* Plugins register their links with registerDashboardProvider API

Signed-off-by: Peter Fitzgibbons <pjfitz@amazon.com>

* Update CHANGELOG.md

Signed-off-by: Josh Romero <rmerqg@amazon.com>

---------

Signed-off-by: Peter Fitzgibbons <pjfitz@amazon.com>
Signed-off-by: Josh Romero <rmerqg@amazon.com>
Co-authored-by: Peter Fitzgibbons <pjfitz@amazon.com>
Co-authored-by: Josh Romero <rmerqg@amazon.com>
(cherry picked from commit d2bd318)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team as a code owner March 30, 2023 23:25
@codecov-commenter
Copy link

codecov-commenter commented Mar 31, 2023

Codecov Report

Merging #3749 (e665f9f) into 2.x (6754c4d) will increase coverage by 0.00%.
The diff coverage is 52.27%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##              2.x    #3749   +/-   ##
=======================================
  Coverage   66.45%   66.46%           
=======================================
  Files        3209     3210    +1     
  Lines       61610    61647   +37     
  Branches     9504     9512    +8     
=======================================
+ Hits        40946    40971   +25     
- Misses      18387    18399   +12     
  Partials     2277     2277           
Flag Coverage Δ
Linux 66.40% <52.27%> (+<0.01%) ⬆️
Windows 66.40% <52.27%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/plugins/dashboard/public/plugin.tsx 0.00% <0.00%> (ø)
...s_react/public/table_list_view/table_list_view.tsx 0.00% <0.00%> (ø)
...board/public/application/listing/create_button.tsx 91.66% <91.66%> (ø)
...rd/public/application/listing/dashboard_listing.js 76.92% <100.00%> (-1.65%) ⬇️

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@kavilla kavilla added the Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry label Mar 31, 2023
@kristenTian kristenTian merged commit cc55a28 into 2.x Apr 4, 2023
@github-actions github-actions bot deleted the backport/backport-3090-to-2.x branch April 4, 2023 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry v2.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants