Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] [Vis Builder] Removed Hard Coded Strings and Used i18n to translate #3189

Merged
merged 1 commit into from
Jan 6, 2023
Merged

[Backport 2.x] [Vis Builder] Removed Hard Coded Strings and Used i18n to translate #3189

merged 1 commit into from
Jan 6, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport b19c171 from #2867.

@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team as a code owner January 6, 2023 02:38
@manasvinibs manasvinibs added v2.5.0 'Issues and PRs related to version v2.5.0' autocut Skip the changelog verification check on backports labels Jan 6, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jan 6, 2023 •
edited
Loading

Codecov Report

Merging #3189 (62d36ff) into 2.x (62d36ff) will not change coverage.
The diff coverage is n/a.

❗ Current head 62d36ff differs from pull request most recent head 1d9d70d. Consider uploading reports for the commit 1d9d70d to get more accurate results

@@           Coverage Diff           @@
##              2.x    #3189   +/-   ##
=======================================
  Coverage   66.61%   66.61%           
=======================================
  Files        3219     3219           
  Lines       61531    61531           
  Branches     9431     9431           
=======================================
  Hits        40986    40986           
  Misses      18303    18303           
  Partials     2242     2242
Flag Coverage Δ
Linux 66.61% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions @manasvinibs
[Vis Builder] Removed Hard Coded Strings and Used i18n to transalte (#…
1d9d70d 
…2867)

Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com>

Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com>
(cherry picked from commit b19c171)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@abbyhu2000 abbyhu2000 merged commit ba932e0 into 2.x Jan 6, 2023
@github-actions github-actions bot deleted the backport/backport-2867-to-2.x branch January 6, 2023 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abbyhu2000 abbyhu2000 abbyhu2000 approved these changes

@manasvinibs manasvinibs manasvinibs approved these changes

Assignees
No one assigned
Labels
autocut Skip the changelog verification check on backports v2.5.0 'Issues and PRs related to version v2.5.0'
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@codecov-commenter @abbyhu2000 @manasvinibs