[Vis Builder] Bug fixes for datasource picker and auto time interval #2632

ashwin-pc · 2022-10-20T10:50:17Z

Description

Fixes Date histogram auto bounds says per 0 millisecond
Fixes Histogram updating bounds when date range updates
Fixes Switching index pattern while editing agg breaks experience

Issues Resolved

#2531 #2310

Check List

codecov-commenter · 2022-10-20T11:37:31Z

Codecov Report

Merging #2632 (3e68839) into main (76d30ec) will decrease coverage by 0.01%.
The diff coverage is 13.33%.

@@            Coverage Diff             @@
##             main    #2632      +/-   ##
==========================================
- Coverage   66.78%   66.76%   -0.02%     
==========================================
  Files        3207     3208       +1     
  Lines       61175    61193      +18     
  Branches     9329     9331       +2     
==========================================
+ Hits        40855    40858       +3     
- Misses      18084    18100      +16     
+ Partials     2236     2235       -1

Impacted Files	Coverage Δ
...pplication/components/data_tab/use/use_dropbox.tsx	`5.97% <0.00%> (+0.33%)`	⬆️
...s_builder/public/application/components/option.tsx	`0.00% <ø> (ø)`
...uilder/public/application/components/workspace.tsx	`4.00% <0.00%> (ø)`
...public/application/utils/state_management/store.ts	`15.00% <ø> (ø)`
...tion/utils/state_management/visualization_slice.ts	`16.66% <0.00%> (-0.48%)`	⬇️
...ilder/public/embeddable/vis_builder_embeddable.tsx	`0.98% <0.00%> (-0.01%)`	⬇️
...ublic/services/type_service/visualization_type.tsx	`100.00% <ø> (ø)`
...lder/public/visualizations/metric/to_expression.ts	`6.12% <ø> (ø)`
.../public/visualizations/vislib/common/create_vis.ts	`11.11% <0.00%> (-5.56%)`	⬇️
...s_builder/public/application/utils/use/use_aggs.ts	`5.88% <5.88%> (ø)`
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

joshuarrrr · 2022-10-20T21:15:26Z

src/plugins/vis_builder/public/visualizations/vislib/common/create_vis.ts

@@ -17,5 +19,14 @@ export const createVis = async (
  vis.data.searchSource = await getSearchService().searchSource.create();
  vis.data.searchSource.setField('index', indexPattern);

+  const responseAggs = vis.data.aggs.getResponseAggs().filter((agg) => agg.enabled);
+  responseAggs.forEach((agg) => {
+    if (isDateHistogramBucketAggConfig(agg)) {


Why does this need to be conditional? Or what would be the harm of setting the timerange param for all aggs?

Good catch. I know the date_histogram bucket agg wont construct the label correctly without this value, but i dont see any reason why it would be a problem for other aggs too. Also this makes me want to spend a lil more time on this change to understand how the agg timeranges work. will update it in a revision

src/plugins/vis_builder/public/application/components/option.tsx

joshuarrrr

I'll admit that I didn't fully follow all the implications of these changes, but this looks much cleaner to me now.

ashwin-pc · 2022-10-24T20:21:55Z

I'll admit that I didn't fully follow all the implications of these changes, but this looks much cleaner to me now.

Thanks for calling that out. Ideally I shouldn't be clubbing more than a single change in a PR but had to since these were all small changes that would have increased churn a lot of they were separate. That being said let me add comments to each change for future visibility.

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

ashwin-pc · 2022-10-25T08:39:27Z

src/core/public/saved_objects/simple_saved_object.ts

@@ -63,8 +63,7 @@ export class SimpleSavedObject<T = unknown> {
      error,
      references,
      migrationVersion,
-      // eslint-disable-next-line @typescript-eslint/naming-convention


This change is simply to remove the eslint exception

ashwin-pc · 2022-10-25T08:56:12Z

src/plugins/vis_builder/public/application/components/workspace.tsx

@@ -50,12 +50,13 @@ export const Workspace: FC = ({ children }) => {
        setExpression(undefined);
        return;
      }
-      const exp = await toExpression(rootState);
+
+      const exp = await toExpression(rootState, searchContext);


Now passing search context too since certain visualizations need the search context data to correctly configure the expression

ashwin-pc · 2022-10-25T08:57:03Z

src/plugins/vis_builder/public/application/utils/validate_schema_state.ts

+ * @param state visualization state
+ * @returns [Validity, 'Message']
+ */
+export const validateSchemaState = (


Simplified this since we can only reliably validate on he visualization state.

ashwin-pc · 2022-10-25T08:58:33Z

src/plugins/vis_builder/public/embeddable/vis_builder_embeddable.tsx

      dirty = true;
    }

-    if (this.handler && dirty) {
-      this.updateHandler();
+    if (dirty) {


We want to recalculate the expression if the context changes too.

abbyhu2000

Thanks for the comments!

opensearch-trigger-bot · 2022-10-26T01:38:32Z

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-2632-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 7a41d9475451be7ae3125590645b0b9a73e8dbb3
# Push it to GitHub
git push --set-upstream origin backport/backport-2632-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-2632-to-2.x.

opensearch-trigger-bot · 2022-11-02T23:08:14Z

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport-2632-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 7a41d9475451be7ae3125590645b0b9a73e8dbb3
# Push it to GitHub
git push --set-upstream origin backport-2632-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport-2632-to-2.x.

opensearch-trigger-bot · 2022-11-02T23:10:07Z

The backport to 2.4 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.4 2.4
# Navigate to the new working tree
pushd ../.worktrees/backport-2.4
# Create a new branch
git switch --create backport-2632-to-2.4
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 7a41d9475451be7ae3125590645b0b9a73e8dbb3
# Push it to GitHub
git push --set-upstream origin backport-2632-to-2.4
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.4

Then, create a pull request where the base branch is 2.4 and the compare/head branch is backport-2632-to-2.4.

…2632) * Fixes auto time interval Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * Fixes change datasource while editing agg Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * Misc fixes Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * Updates Changelog Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * Correctly sets timerange Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * Fixes rebase Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> (cherry picked from commit 7a41d94) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

…2632) (#2765) * Fixes auto time interval Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * Fixes change datasource while editing agg Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * Misc fixes Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * Updates Changelog Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * Correctly sets timerange Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * Fixes rebase Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> (cherry picked from commit 7a41d94) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

opensearch-trigger-bot · 2022-11-03T17:48:22Z

The backport to 2.4 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.4 2.4
# Navigate to the new working tree
pushd ../.worktrees/backport-2.4
# Create a new branch
git switch --create backport-2632-to-2.4
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 7a41d9475451be7ae3125590645b0b9a73e8dbb3
# Push it to GitHub
git push --set-upstream origin backport-2632-to-2.4
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.4

Then, create a pull request where the base branch is 2.4 and the compare/head branch is backport-2632-to-2.4.

…pensearch-project#2632) (opensearch-project#2765) * Fixes auto time interval Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * Fixes change datasource while editing agg Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * Misc fixes Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * Updates Changelog Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * Correctly sets timerange Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * Fixes rebase Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> (cherry picked from commit 7a41d94) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

…pensearch-project#2632) * Fixes auto time interval Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * Fixes change datasource while editing agg Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * Misc fixes Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * Updates Changelog Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * Correctly sets timerange Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * Fixes rebase Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> Signed-off-by: Sergey V. Osipov <sipopo@yandex.ru>

…pensearch-project#2632) * Fixes auto time interval Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * Fixes change datasource while editing agg Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * Misc fixes Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * Updates Changelog Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * Correctly sets timerange Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * Fixes rebase Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> Signed-off-by: Arpit Bandejiya <abandeji@amazon.com>

ashwin-pc requested a review from a team as a code owner October 20, 2022 10:50

ashwin-pc added vis builder backport 2.x labels Oct 20, 2022

ananzh added the v2.4.0 'Issues and PRs related to version v2.4.0' label Oct 20, 2022

joshuarrrr previously approved these changes Oct 20, 2022

View reviewed changes

ashwin-pc dismissed joshuarrrr’s stale review via 61f79f8 October 21, 2022 03:52

joshuarrrr previously approved these changes Oct 21, 2022

View reviewed changes

ashwin-pc added 5 commits October 25, 2022 08:09

Fixes auto time interval

c64a745

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

Fixes change datasource while editing agg

3fcc3a1

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

Misc fixes

1566268

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

Updates Changelog

15cc636

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

Correctly sets timerange

b9eb5d2

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

ashwin-pc dismissed joshuarrrr’s stale review via b9eb5d2 October 25, 2022 08:10

ashwin-pc force-pushed the fix/datasource-change branch from 61f79f8 to b9eb5d2 Compare October 25, 2022 08:10

Fixes rebase

3e68839

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

ashwin-pc commented Oct 25, 2022

View reviewed changes

joshuarrrr approved these changes Oct 26, 2022

View reviewed changes

abbyhu2000 approved these changes Oct 26, 2022

View reviewed changes

ashwin-pc merged commit 7a41d94 into opensearch-project:main Oct 26, 2022

AMoo-Miki added backport 2.x backport 2.4 and removed backport 2.x labels Nov 2, 2022

AMoo-Miki added backport 2.x and removed backport 2.x labels Nov 3, 2022

opensearch-trigger-bot bot mentioned this pull request Nov 3, 2022

[Backport 2.x] [Vis Builder] Bug fixes for datasource picker and auto time interval #2765

Merged

AMoo-Miki added backport 2.4 and removed backport 2.4 labels Nov 3, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Vis Builder] Bug fixes for datasource picker and auto time interval #2632

[Vis Builder] Bug fixes for datasource picker and auto time interval #2632

ashwin-pc commented Oct 20, 2022 •

edited

Loading

codecov-commenter commented Oct 20, 2022 •

edited

Loading

joshuarrrr Oct 20, 2022

ashwin-pc Oct 21, 2022

joshuarrrr left a comment

ashwin-pc commented Oct 24, 2022

ashwin-pc Oct 25, 2022

ashwin-pc Oct 25, 2022

ashwin-pc Oct 25, 2022

ashwin-pc Oct 25, 2022

abbyhu2000 left a comment

opensearch-trigger-bot bot commented Oct 26, 2022

opensearch-trigger-bot bot commented Nov 2, 2022

opensearch-trigger-bot bot commented Nov 2, 2022

opensearch-trigger-bot bot commented Nov 3, 2022

[Vis Builder] Bug fixes for datasource picker and auto time interval #2632

[Vis Builder] Bug fixes for datasource picker and auto time interval #2632

Conversation

ashwin-pc commented Oct 20, 2022 • edited Loading

Description

Issues Resolved

Check List

codecov-commenter commented Oct 20, 2022 • edited Loading

Codecov Report

joshuarrrr Oct 20, 2022

Choose a reason for hiding this comment

ashwin-pc Oct 21, 2022

Choose a reason for hiding this comment

joshuarrrr left a comment

Choose a reason for hiding this comment

ashwin-pc commented Oct 24, 2022

ashwin-pc Oct 25, 2022

Choose a reason for hiding this comment

ashwin-pc Oct 25, 2022

Choose a reason for hiding this comment

ashwin-pc Oct 25, 2022

Choose a reason for hiding this comment

ashwin-pc Oct 25, 2022

Choose a reason for hiding this comment

abbyhu2000 left a comment

Choose a reason for hiding this comment

opensearch-trigger-bot bot commented Oct 26, 2022

opensearch-trigger-bot bot commented Nov 2, 2022

opensearch-trigger-bot bot commented Nov 2, 2022

opensearch-trigger-bot bot commented Nov 3, 2022

ashwin-pc commented Oct 20, 2022 •

edited

Loading

codecov-commenter commented Oct 20, 2022 •

edited

Loading