Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Use a forced CSP-compliant interpreter with Vega visualizations #2354

Merged
merged 1 commit into from
Sep 15, 2022

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport bebbcca from #2352

* Pass `options` to `vega.parse` to enable inclusion of parsed ASTs
* Introduce the forced CSP-compliant interpreter that prevents evaluation of unsafe methods
* Modified the consumed `leaflet-vega` package to one that honors `options`

Signed-off-by: Miki <miki@amazon.com>

Signed-off-by: Miki <miki@amazon.com>
(cherry picked from commit bebbcca)
@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team as a code owner September 14, 2022 22:20
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (2.x@c60b5e4). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head bebbcca differs from pull request most recent head 82e5ab1. Consider uploading reports for the commit 82e5ab1 to get more accurate results

@@          Coverage Diff           @@
##             2.x    #2354   +/-   ##
======================================
  Coverage       ?   66.55%           
======================================
  Files          ?     3170           
  Lines          ?    60318           
  Branches       ?     9181           
======================================
  Hits           ?    40142           
  Misses         ?    17983           
  Partials       ?     2193           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@kavilla kavilla merged commit 6b9ef73 into 2.x Sep 15, 2022
@github-actions github-actions bot deleted the backport/backport-2352-to-2.x branch September 15, 2022 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants