Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean escloud -1 #191

Merged
merged 2 commits into from
Mar 19, 2021
Merged

clean escloud -1 #191

merged 2 commits into from
Mar 19, 2021

Conversation

ananzh
Copy link
Member

@ananzh ananzh commented Mar 19, 2021

Signed-off-by: Anan Zhuang ananzh@amazon.com

Clean out elastic cloud content in /src/plugins/home/server/tutorials/*
Change some elastic words --> opensearch
No change for elastic.co bc they all changed in PR-173
*Todo:
There might be some logos that need further check, like logoStash.
Some commands that need to be checked again whether we should change:
1)'curl -L -O https://artifacts.elastic.co/downloads/beats/functionbeat/functionbeat-{config.opensearchDashboards.version}-darwin-x86_64.tar.gz',
'tar xzvf functionbeat-{config.opensearchDashboards.version}-darwin-x86_64.tar.gz',
'cd functionbeat-{config.opensearchDashboards.version}-darwin-x86_64/',
2)sudo service heartbeat-elastic star

Others all clean

@odfe-release-bot
Copy link

✅   DCO Check Passed

@kavilla
Copy link
Member

kavilla commented Mar 19, 2021

Running the linter a couple errors exist. Seems to just be from the extra whitelines. eslint should be able to fix it for you. Just run yarn lint:es --fix and add that commit.

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
@odfe-release-bot
Copy link

✅   DCO Check Passed

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
@odfe-release-bot
Copy link

✅   DCO Check Passed

Copy link
Contributor

@boktorbb boktorbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ananzh
Copy link
Member Author

ananzh commented Mar 19, 2021

Clean out elastic cloud contents in /src/plugins/home/server/tutorials

@ananzh ananzh merged commit f36222b into opensearch-project:dashboards Mar 19, 2021
@kavilla
Copy link
Member

kavilla commented Mar 19, 2021

Seeing lint errors when running yarn lint

Looks easy to fix with yarn lint:es --fix

Hailong-am pushed a commit to Hailong-am/OpenSearch-Dashboards that referenced this pull request Sep 25, 2023
…pensearch-project#197)

rename workspace service class name and types

---------

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Hailong-am pushed a commit to Hailong-am/OpenSearch-Dashboards that referenced this pull request Sep 27, 2023
Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
SuZhou-Joe pushed a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Oct 7, 2023
Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
SuZhou-Joe pushed a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Oct 7, 2023
Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants