Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Rename] maps-legacy plugin #130

Merged
merged 2 commits into from
Mar 12, 2021
Merged

[Rename] maps-legacy plugin #130

merged 2 commits into from
Mar 12, 2021

Conversation

kavilla
Copy link
Member

@kavilla kavilla commented Mar 9, 2021

Signed-off-by: Kawika Avilla kavilla414@gmail.com

Issue #, if available:
#37

Description of changes:
Rename files and variables within plugins/maps-legacy

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

mihirsoni
mihirsoni approved these changes Mar 10, 2021
View reviewed changes
Copy link
Contributor

@mihirsoni mihirsoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!

boktorbb
boktorbb suggested changes Mar 11, 2021
View reviewed changes
Copy link
Contributor

@boktorbb boktorbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you look at all the elastic urls that were changed? opensearch.co is meaningless

src/plugins/maps_legacy/opensearch_dashboards.json Outdated Show resolved Hide resolved
src/plugins/maps_legacy/public/__tests__/map/ems_mocks/sample_files.json Show resolved Hide resolved
src/plugins/maps_legacy/public/__tests__/map/ems_mocks/sample_files.json Show resolved Hide resolved
src/plugins/maps_legacy/public/__tests__/map/ems_mocks/sample_files.json Show resolved Hide resolved
src/plugins/maps_legacy/public/__tests__/map/ems_mocks/sample_files.json Show resolved Hide resolved
src/plugins/maps_legacy/public/__tests__/map/ems_mocks/sample_files.json Show resolved Hide resolved
src/plugins/maps_legacy/public/__tests__/map/ems_mocks/sample_files.json Show resolved Hide resolved
src/plugins/maps_legacy/public/__tests__/map/ems_mocks/sample_files.json Show resolved Hide resolved
src/plugins/maps_legacy/public/__tests__/map/ems_mocks/sample_files.json Show resolved Hide resolved
src/plugins/maps_legacy/public/__tests__/map/ems_mocks/sample_files.json Show resolved Hide resolved
@kavilla
Copy link
Member Author

kavilla commented Mar 12, 2021

@boktorbb-amzn

Could you look at all the elastic urls that were changed? opensearch.co is meaningless

For me is that I thought it was mostly just sample data anyways so I updated it just to get elastic out of the file. You are right. I can revert it back if you would like

@kavilla
[Rename] maps-legacy plugin
e4368ae 
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
@kavilla
Address PR comments
c419e41 
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
@kavilla kavilla requested a review from boktorbb March 12, 2021 22:18
@kavilla
Copy link
Member Author

kavilla commented Mar 12, 2021

Updated, for the references of elastic.co we updated because it was in a test file.

boktorbb
boktorbb approved these changes Mar 12, 2021
View reviewed changes
Copy link
Contributor

@boktorbb boktorbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@boktorbb boktorbb merged commit 03c50db into opensearch-project:dashboards Mar 12, 2021
@kavilla kavilla deleted the rename-maps-legacy branch March 18, 2021 08:01
kavilla referenced this pull request in kavilla/OpenSearch-Dashboards Mar 19, 2021
@kavilla
[Rename] maps-legacy plugin (#130)
d6cafeb 
* [Rename] maps-legacy plugin

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* Address PR comments

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
kavilla added a commit that referenced this pull request Mar 20, 2021
@kavilla
[Rename] maps-legacy plugin (#130)
916bfeb 
* [Rename] maps-legacy plugin

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* Address PR comments

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
mihirsoni pushed a commit that referenced this pull request Mar 20, 2021
@kavilla @mihirsoni
[Rename] maps-legacy plugin (#130)
d263443 
* [Rename] maps-legacy plugin

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* Address PR comments

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
gaobinlong pushed a commit to gaobinlong/OpenSearch-Dashboards that referenced this pull request Sep 12, 2023
@SuZhou-Joe
[Feature] Setup workspace skeleton and implement basic CRUD API (open…
c3bc14b 
…search-project#130)

* feature: setup workspace skeleton and implement basic CRUD API on workspace

Signed-off-by: Zhou Su <suzhou@dev-dsk-suzhou-2a-8ce7a7a7.us-west-2.amazon.com>

* feat: remove useless required plugins and logger typo

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: setup public side skeleton

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

---------

Signed-off-by: Zhou Su <suzhou@dev-dsk-suzhou-2a-8ce7a7a7.us-west-2.amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Co-authored-by: Zhou Su <suzhou@dev-dsk-suzhou-2a-8ce7a7a7.us-west-2.amazon.com>
gaobinlong pushed a commit to gaobinlong/OpenSearch-Dashboards that referenced this pull request Sep 20, 2023
@SuZhou-Joe @ruanyl
[Feature] Setup workspace skeleton and implement basic CRUD API (open…
074d23b 
…search-project#130)

* feature: setup workspace skeleton and implement basic CRUD API on workspace

Signed-off-by: Zhou Su <suzhou@dev-dsk-suzhou-2a-8ce7a7a7.us-west-2.amazon.com>

* feat: remove useless required plugins and logger typo

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: setup public side skeleton

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

---------

Signed-off-by: Zhou Su <suzhou@dev-dsk-suzhou-2a-8ce7a7a7.us-west-2.amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Co-authored-by: Zhou Su <suzhou@dev-dsk-suzhou-2a-8ce7a7a7.us-west-2.amazon.com>
SuZhou-Joe added a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Sep 21, 2023
@SuZhou-Joe
[Feature] Setup workspace skeleton and implement basic CRUD API (open…
e077f34 
…search-project#130)

* feature: setup workspace skeleton and implement basic CRUD API on workspace

Signed-off-by: Zhou Su <suzhou@dev-dsk-suzhou-2a-8ce7a7a7.us-west-2.amazon.com>

* feat: remove useless required plugins and logger typo

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: setup public side skeleton

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

---------

Signed-off-by: Zhou Su <suzhou@dev-dsk-suzhou-2a-8ce7a7a7.us-west-2.amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Co-authored-by: Zhou Su <suzhou@dev-dsk-suzhou-2a-8ce7a7a7.us-west-2.amazon.com>
SuZhou-Joe added a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Sep 21, 2023
@SuZhou-Joe
[Feature] Setup workspace skeleton and implement basic CRUD API (open…
4fbca9e 
…search-project#130)

* feature: setup workspace skeleton and implement basic CRUD API on workspace

Signed-off-by: Zhou Su <suzhou@dev-dsk-suzhou-2a-8ce7a7a7.us-west-2.amazon.com>

* feat: remove useless required plugins and logger typo

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: setup public side skeleton

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

---------

Signed-off-by: Zhou Su <suzhou@dev-dsk-suzhou-2a-8ce7a7a7.us-west-2.amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Co-authored-by: Zhou Su <suzhou@dev-dsk-suzhou-2a-8ce7a7a7.us-west-2.amazon.com>
wanglam pushed a commit to wanglam/OpenSearch-Dashboards that referenced this pull request Feb 22, 2024
@SuZhou-Joe @wanglam
[Feature] Setup workspace skeleton and implement basic CRUD API (open…
9325402 
…search-project#130)

* feature: setup workspace skeleton and implement basic CRUD API on workspace

Signed-off-by: Zhou Su <suzhou@dev-dsk-suzhou-2a-8ce7a7a7.us-west-2.amazon.com>

* feat: remove useless required plugins and logger typo

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: setup public side skeleton

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

---------

Signed-off-by: Zhou Su <suzhou@dev-dsk-suzhou-2a-8ce7a7a7.us-west-2.amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Co-authored-by: Zhou Su <suzhou@dev-dsk-suzhou-2a-8ce7a7a7.us-west-2.amazon.com>
SuZhou-Joe added a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Mar 18, 2024
@SuZhou-Joe
[Feature] Setup workspace skeleton and implement basic CRUD API (open…
450ed0f 
…search-project#130)

* feature: setup workspace skeleton and implement basic CRUD API on workspace

Signed-off-by: Zhou Su <suzhou@dev-dsk-suzhou-2a-8ce7a7a7.us-west-2.amazon.com>

* feat: remove useless required plugins and logger typo

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: setup public side skeleton

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

---------

Signed-off-by: Zhou Su <suzhou@dev-dsk-suzhou-2a-8ce7a7a7.us-west-2.amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Co-authored-by: Zhou Su <suzhou@dev-dsk-suzhou-2a-8ce7a7a7.us-west-2.amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihirsoni mihirsoni mihirsoni approved these changes

@boktorbb boktorbb boktorbb approved these changes

@seanneumann seanneumann Awaiting requested review from seanneumann

Assignees
No one assigned
Labels
rename
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kavilla @mihirsoni @boktorbb