Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG][Data Explorer] SearchOnPageLoad does not work #5057

Closed
abbyhu2000 opened this issue Sep 18, 2023 · 1 comment
Closed

[BUG][Data Explorer] SearchOnPageLoad does not work #5057

abbyhu2000 opened this issue Sep 18, 2023 · 1 comment
Assignees
Labels
bug Something isn't working data explorer Issues related to the Data Explorer project de-angular de-angularize work discover for discover reinvent v2.11.0

Comments

@abbyhu2000
Copy link
Member

Describe the bug
If SearchOnPageLoad is turned on, the discover page should not show search result immediately, but show a page saying Start searching.
Screenshot 2023-09-18 at 2 56 39 PM

Currently, the behavior is the same whether SearchOnPageLoad is turned on or off, it always loads the result immediately on page load:

Screen.Recording.2023-09-18.at.2.55.02.PM.mov

Expected:

Screen.Recording.2023-09-18.at.2.55.30.PM.mov
@abbyhu2000 abbyhu2000 added bug Something isn't working untriaged data explorer Issues related to the Data Explorer project labels Sep 18, 2023
@ashwin-pc ashwin-pc added discover for discover reinvent de-angular de-angularize work v2.11.0 and removed untriaged labels Sep 18, 2023
@ananzh
Copy link
Member

ananzh commented Sep 20, 2023

This is a missing! Great catch!

@abbyhu2000 abbyhu2000 self-assigned this Sep 20, 2023
kavilla pushed a commit to opensearch-project/opensearch-dashboards-functional-test that referenced this issue Oct 13, 2023
Migrate the old selenium tests for discover to cypress tests for data explorer.
PR [for #5003](opensearch-project/OpenSearch-Dashboards#5072) needs to be merged first.

Below are a list of bugs found when writing the tests, the tests for the below feature are skipped and commented with the issue link:

- opensearch-project/OpenSearch-Dashboards#5071
- opensearch-project/OpenSearch-Dashboards#5068
- opensearch-project/OpenSearch-Dashboards#5058
- opensearch-project/OpenSearch-Dashboards#5057
- opensearch-project/OpenSearch-Dashboards#5056

### Issues Resolved
resolves opensearch-project/OpenSearch-Dashboards#4781

---------

Signed-off-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
opensearch-trigger-bot bot pushed a commit to opensearch-project/opensearch-dashboards-functional-test that referenced this issue Oct 13, 2023
Migrate the old selenium tests for discover to cypress tests for data explorer.
PR [for #5003](opensearch-project/OpenSearch-Dashboards#5072) needs to be merged first.

Below are a list of bugs found when writing the tests, the tests for the below feature are skipped and commented with the issue link:

- opensearch-project/OpenSearch-Dashboards#5071
- opensearch-project/OpenSearch-Dashboards#5068
- opensearch-project/OpenSearch-Dashboards#5058
- opensearch-project/OpenSearch-Dashboards#5057
- opensearch-project/OpenSearch-Dashboards#5056

### Issues Resolved
resolves opensearch-project/OpenSearch-Dashboards#4781

---------

Signed-off-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
(cherry picked from commit 7cf0a03)
opensearch-trigger-bot bot pushed a commit to opensearch-project/opensearch-dashboards-functional-test that referenced this issue Oct 13, 2023
Migrate the old selenium tests for discover to cypress tests for data explorer.
PR [for #5003](opensearch-project/OpenSearch-Dashboards#5072) needs to be merged first.

Below are a list of bugs found when writing the tests, the tests for the below feature are skipped and commented with the issue link:

- opensearch-project/OpenSearch-Dashboards#5071
- opensearch-project/OpenSearch-Dashboards#5068
- opensearch-project/OpenSearch-Dashboards#5058
- opensearch-project/OpenSearch-Dashboards#5057
- opensearch-project/OpenSearch-Dashboards#5056

### Issues Resolved
resolves opensearch-project/OpenSearch-Dashboards#4781

---------

Signed-off-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
(cherry picked from commit 7cf0a03)
kavilla pushed a commit to opensearch-project/opensearch-dashboards-functional-test that referenced this issue Oct 13, 2023
Migrate the old selenium tests for discover to cypress tests for data explorer.
PR [for #5003](opensearch-project/OpenSearch-Dashboards#5072) needs to be merged first.

Below are a list of bugs found when writing the tests, the tests for the below feature are skipped and commented with the issue link:

- opensearch-project/OpenSearch-Dashboards#5071
- opensearch-project/OpenSearch-Dashboards#5068
- opensearch-project/OpenSearch-Dashboards#5058
- opensearch-project/OpenSearch-Dashboards#5057
- opensearch-project/OpenSearch-Dashboards#5056

### Issues Resolved
resolves opensearch-project/OpenSearch-Dashboards#4781

---------

Signed-off-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
(cherry picked from commit 7cf0a03)

Co-authored-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
kavilla pushed a commit to opensearch-project/opensearch-dashboards-functional-test that referenced this issue Oct 13, 2023
Migrate the old selenium tests for discover to cypress tests for data explorer.
PR [for #5003](opensearch-project/OpenSearch-Dashboards#5072) needs to be merged first.

Below are a list of bugs found when writing the tests, the tests for the below feature are skipped and commented with the issue link:

- opensearch-project/OpenSearch-Dashboards#5071
- opensearch-project/OpenSearch-Dashboards#5068
- opensearch-project/OpenSearch-Dashboards#5058
- opensearch-project/OpenSearch-Dashboards#5057
- opensearch-project/OpenSearch-Dashboards#5056

### Issues Resolved
resolves opensearch-project/OpenSearch-Dashboards#4781

---------

Signed-off-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
(cherry picked from commit 7cf0a03)

Co-authored-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working data explorer Issues related to the Data Explorer project de-angular de-angularize work discover for discover reinvent v2.11.0
Projects
None yet
Development

No branches or pull requests

3 participants