-
Notifications
You must be signed in to change notification settings - Fork 870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Git] Do not run full build-test workflow on markdown only changes #1214
Labels
Comments
Example PR that did not need to run the full test suite: #1213 |
kavilla
changed the title
[Git] don't run full build-test workflow on markdown only changes
[Git] Do not run full build-test workflow on markdown only changes
Feb 4, 2022
I think it is okay to skip linter test for markdown only changes as well? Since i verified that linter test does not look at markdown files. @kavilla |
7 tasks
Yeah, eventually I'd love to actually have markdown linting, but that's a low-priority item for the moment. |
kavilla
pushed a commit
that referenced
this issue
Sep 14, 2022
To save resources and job runners, some PRs do not need to run the full test suite. For PRs and pushes with markdown changes only, the build and test workflow will be skipped. (Linter test should be okay to skipped since it will automatically run with every commit). For PRs and pushes with markdown changes along with other changes, the build and test workflow will not be skipped. Issue Resolved: #1214 Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this issue
Sep 14, 2022
To save resources and job runners, some PRs do not need to run the full test suite. For PRs and pushes with markdown changes only, the build and test workflow will be skipped. (Linter test should be okay to skipped since it will automatically run with every commit). For PRs and pushes with markdown changes along with other changes, the build and test workflow will not be skipped. Issue Resolved: #1214 Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> (cherry picked from commit ab99eac)
sipopo
pushed a commit
to sipopo/OpenSearch-Dashboards
that referenced
this issue
Sep 14, 2022
To save resources and job runners, some PRs do not need to run the full test suite. For PRs and pushes with markdown changes only, the build and test workflow will be skipped. (Linter test should be okay to skipped since it will automatically run with every commit). For PRs and pushes with markdown changes along with other changes, the build and test workflow will not be skipped. Issue Resolved: opensearch-project#1214 Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> Signed-off-by: Sergey V. Osipov <sipopo@yandex.ru>
kavilla
pushed a commit
that referenced
this issue
Sep 15, 2022
To save resources and job runners, some PRs do not need to run the full test suite. For PRs and pushes with markdown changes only, the build and test workflow will be skipped. (Linter test should be okay to skipped since it will automatically run with every commit). For PRs and pushes with markdown changes along with other changes, the build and test workflow will not be skipped. Issue Resolved: #1214 Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> (cherry picked from commit ab99eac) Co-authored-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
sipopo
pushed a commit
to sipopo/OpenSearch-Dashboards
that referenced
this issue
Dec 16, 2022
To save resources and job runners, some PRs do not need to run the full test suite. For PRs and pushes with markdown changes only, the build and test workflow will be skipped. (Linter test should be okay to skipped since it will automatically run with every commit). For PRs and pushes with markdown changes along with other changes, the build and test workflow will not be skipped. Issue Resolved: opensearch-project#1214 Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> Signed-off-by: Sergey V. Osipov <sipopo@yandex.ru>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
When creating a PR with only markdown file changes for example
README.md
, it shouldn't be blocked by build and testing.Describe the solution you'd like
Have the linter only run if the PR only contains markdown changes. It looks like
paths-ignore
can be used to wildcard catch**.md
[DOCS]Describe alternatives you've considered
N/A
Additional context
I believe it is safe to wildcard
**.md
to only run the lint but we should verify if we need to be more specific.The text was updated successfully, but these errors were encountered: