Skip to content

Commit

Permalink
address comments
Browse files Browse the repository at this point in the history
Signed-off-by: Joshua Li <joshuali925@gmail.com>
  • Loading branch information
joshuali925 committed Jun 17, 2024
1 parent edb0390 commit 886ace5
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
3 changes: 1 addition & 2 deletions src/plugins/data/public/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -464,6 +464,7 @@ export {
TimeHistoryContract,
QueryStateChange,
QueryStart,
PersistedLog,
} from './query';

export { AggsStart } from './search/aggs';
Expand Down Expand Up @@ -526,5 +527,3 @@ export {
DataSourceGroup,
DataSourceOption,
} from './data_sources/datasource_selector';

export { PersistedLog } from './query';
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ const QueryEditorExtensionPortal: React.FC<{ container: Element }> = (props) =>

export const QueryEditorExtension: React.FC<QueryEditorExtensionProps> = (props) => {
const [isEnabled, setIsEnabled] = useState(false);
const isMounted = useRef(true);
const isMounted = useRef(false);

const banner = useMemo(() => props.config.getBanner?.(props.dependencies), [
props.config,
Expand Down

0 comments on commit 886ace5

Please sign in to comment.