Skip to content

Commit

Permalink
Make table size adjustable according to table rows and columns
Browse files Browse the repository at this point in the history
* Provide a unique key prop to the table component to force it to fully
re-render when the key changes, which will force table to adjust its size.

Issue Resolved
#5440

Signed-off-by: Anan Z <ananzh@amazon.com>
  • Loading branch information
ananzh committed Feb 5, 2024
1 parent 7c0bd9f commit 51e04f8
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
- [Discover] Fix missing index pattern field from breaking Discover [#5626](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/5626)
- [BUG] Remove duplicate sample data as id 90943e30-9a47-11e8-b64d-95841ca0b247 ([5668](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/5668))
- [BUG][Multiple Datasource] Fix datasource testing connection unexpectedly passed with wrong endpoint [#5663](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/5663)
- [BUG][Discover] Make table size adjustable according to table rows and columns ([#5514](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/5514))

### 🚞 Infrastructure

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,7 @@ export default function DiscoverCanvas({ setHeaderActionMenu, history }: ViewPro
}, [dispatch, filteredColumns, indexPattern]);

const timeField = indexPattern?.timeFieldName ? indexPattern.timeFieldName : undefined;
const lastColumn = columns ? columns[columns.length - 1] : '';

return (
<EuiPanel
Expand Down Expand Up @@ -118,7 +119,7 @@ export default function DiscoverCanvas({ setHeaderActionMenu, history }: ViewPro
<MemoizedDiscoverChartContainer {...fetchState} />
</EuiPanel>
</EuiPanel>
<MemoizedDiscoverTable rows={rows} />
<MemoizedDiscoverTable key={`table-${rows?.length}-${lastColumn}`} rows={rows} />
</>
)}
</EuiPanel>
Expand Down

0 comments on commit 51e04f8

Please sign in to comment.