InstanceOfPatternMatch: handle same type for multiple operands
#265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickie
force-pushed
the
rossendrijver/instanceofpatternmatch_bug
branch
from
735b18b
to
f817498
Compare
|
Thanks for the report! I think this is a variant of this case which contains some earlier attempts Definitely something we'd want to see resolved. |
|
Exploring a likely fix in |
timtebeek
added a commit
to KoTurk/rewrite-static-analysis
that referenced
this pull request
Mar 4, 2024
|
I've merged this test into #175 ; let's continue there. |
|
Thanks Tim 😄! I should've noticed the other issue before opening this one... |
timtebeek
added a commit
that referenced
this pull request
Jul 14, 2024
…#175) * Added failing JUnit test for issue "Duplicate variable name in if statement with two different instanceof" * Add issue link * Move and update test; include #265 * Update expectations & handle binary separately * Demonstrate known failure --------- Co-authored-by: Ko Turk <turkk@Kos-MacBook-Pro.local> Co-authored-by: Tim te Beek <tim@moderne.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
This introduces a failing unit test for the
InstanceOfPatternmatchrecipe.We are giving the same name to the variable while we have an expression with two operands that check the same type.
What's your motivation?
The code in the "after" template is incorrect as it gives the following error:
Any additional context
I'm curious how we can fix this. It doesn't seem trivial, so probably I don't have time right now to create a fix myself.
Checklist