Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update python to go along with matlab changes in 9beee53 #278

Merged
merged 28 commits into from
May 10, 2024
Merged

update python to go along with matlab changes in 9beee53 #278

merged 28 commits into from
May 10, 2024

Commits on Feb 26, 2024

  1. update python to go along with matlab changes in 9beee53

    @bendhouseart
    bendhouseart committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    91136ea View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2024

  1. Merge branch 'main' of github.com:openneuropet/PET2BIDS into 272-ecat… 

    …-bug-fbp-scaling-negative-values-error
    @bendhouseart
    bendhouseart committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    1f158f8 View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2024

  1. These these modifications are helping? 

    It seems like as I more closely approach the matlab code in read_ecat
and ecat2nii the image quality of the python images continues to
decrease.
    @bendhouseart
    bendhouseart committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    9dfc2b0 View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2024

  1. moved int testing to this repo

    @bendhouseart
    bendhouseart committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    06a3ce0 View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2024

  1. remove redundant step 1

    @bendhouseart
    bendhouseart committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    b0fd706 View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2024

  1. update readme

    @bendhouseart
    bendhouseart committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    bee1571 View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2024

  1. nothing wrong with reading

    @bendhouseart
    bendhouseart committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    24cb01c View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2024

  1. steady as she goes

    @bendhouseart
    bendhouseart committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    7ac1aa8 View commit details
    Browse the repository at this point in the history

  2. need to make a new output function for first_middle_last_frames_to_te… 

    …xt for arrays since they're different than cell arrays.
    @bendhouseart
    bendhouseart committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    2c2d89e View commit details
    Browse the repository at this point in the history

  3. things diverge after step 7

    @bendhouseart
    bendhouseart committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    b8b21fd View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2024

  1. step 8 now matches between python and matlab

    @bendhouseart
    bendhouseart committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    d9831b3 View commit details
    Browse the repository at this point in the history

  2. rounding...

    @bendhouseart
    bendhouseart committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    3e38914 View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2024

  1. it's the nifti's that are the issue..

    @bendhouseart
    bendhouseart committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    7b41bb6 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2024

  1. fixed min/max, need to check difference between outputs before final … 

    …:thumbs up:
    @bendhouseart
    bendhouseart committed May 9, 2024
    Configuration menu
    Copy the full SHA
    161ca42 View commit details
    Browse the repository at this point in the history

  2. Update ecat2nii.py (#308) 

    * Use more idiomatic way of constructing an affine
* Remove unnecessary header zeroing, use helper methods where appropriate
    @effigies
    effigies authored May 9, 2024
    Configuration menu
    Copy the full SHA
    f25cdd2 View commit details
    Browse the repository at this point in the history

  3. add seconds back

    @bendhouseart
    bendhouseart authored May 9, 2024
    Configuration menu
    Copy the full SHA
    13e9271 View commit details
    Browse the repository at this point in the history

  4. Update matlab/nii_tool.m remove print

    @bendhouseart
    bendhouseart authored May 9, 2024
    Configuration menu
    Copy the full SHA
    2392575 View commit details
    Browse the repository at this point in the history

  5. Update matlab/ecat2nii.m uncomment commented out catch

    @bendhouseart
    bendhouseart authored May 9, 2024
    Configuration menu
    Copy the full SHA
    6dd9a78 View commit details
    Browse the repository at this point in the history

  6. added seconds back in

    @bendhouseart
    bendhouseart committed May 9, 2024
    Configuration menu
    Copy the full SHA
    202ed34 View commit details
    Browse the repository at this point in the history

  7. Merge branch '272-ecat-bug-fbp-scaling-negative-values-error' of gith… 

    …ub.com:openneuropet/PET2BIDS into 272-ecat-bug-fbp-scaling-negative-values-error
    @bendhouseart
    bendhouseart committed May 9, 2024
    Configuration menu
    Copy the full SHA
    ba09063 View commit details
    Browse the repository at this point in the history

  8. put try/catch back in

    @bendhouseart
    bendhouseart committed May 9, 2024
    Configuration menu
    Copy the full SHA
    f946848 View commit details
    Browse the repository at this point in the history

  9. is this what's crashing ci?

    @bendhouseart
    bendhouseart committed May 9, 2024
    Configuration menu
    Copy the full SHA
    87e7f91 View commit details
    Browse the repository at this point in the history

  10. add ad-hoc final test script

    @bendhouseart
    bendhouseart committed May 9, 2024
    Configuration menu
    Copy the full SHA
    a029106 View commit details
    Browse the repository at this point in the history

  11. Merge branch 'main' into 272-ecat-bug-fbp-scaling-negative-values-error 

    # Conflicts:
#	.gitignore
#	pypet2bids/pypet2bids/ecat2nii.py
#	pypet2bids/pypet2bids/read_ecat.py
    @bendhouseart
    bendhouseart committed May 9, 2024
    Configuration menu
    Copy the full SHA
    eb0261e View commit details
    Browse the repository at this point in the history

  12. run black, add conditional for testing

    @bendhouseart
    bendhouseart committed May 9, 2024
    Configuration menu
    Copy the full SHA
    c3b4d66 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2024

  1. Apply suggestions from code review 

    fixed % and added rms

Co-authored-by: Chris Markiewicz <effigies@gmail.com>
    @bendhouseart @effigies
    bendhouseart and effigies authored May 10, 2024
    Configuration menu
    Copy the full SHA
    0e3422c View commit details
    Browse the repository at this point in the history

  2. Update ecat_testing/read_matlab_nii.py 

    Co-authored-by: Chris Markiewicz <effigies@gmail.com>
    @bendhouseart @effigies
    bendhouseart and effigies authored May 10, 2024
    Configuration menu
    Copy the full SHA
    ad7368f View commit details
    Browse the repository at this point in the history

  3. bump version before merge to main

    @bendhouseart
    bendhouseart committed May 10, 2024
    Configuration menu
    Copy the full SHA
    28a7db0 View commit details
    Browse the repository at this point in the history