Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EIP-136: Add release GitHub Action workflow. #61

Merged
merged 2 commits into from
May 20, 2024
Merged

Conversation

corneliouzbett
Copy link
Member

@corneliouzbett corneliouzbett commented May 20, 2024

Issue: https://openmrs.atlassian.net/browse/EIP-136

This PR adds GA release workflow.

Copy link
Member

@Ruhanga Ruhanga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM. However can we rather add an OpenMRS related Jira ticket instead the internal Ozone one?

@corneliouzbett corneliouzbett changed the title OZ-497: Add GitHub Action release workflow. EIP-136: Add GitHub Action release workflow. May 20, 2024
@corneliouzbett
Copy link
Member Author

Generally LGTM. However can we rather add an OpenMRS related Jira ticket instead the internal Ozone one?

I believe it's ok to use internal Ozone tickets, we are already using for some of the issues(PRs).

@corneliouzbett corneliouzbett changed the title EIP-136: Add GitHub Action release workflow. EIP-136: Add release GitHub Action workflow. May 20, 2024
@Ruhanga
Copy link
Member

Ruhanga commented May 20, 2024

I believe it's ok to use internal Ozone tickets, we are already using for some of the issues(PRs).

It seems like an oversight, especially considering there's a dedicated OpenMRS Jira project meant to track activity on this repository. It would also be beneficial for other teams to easily grasp the context of what's being resolved.

@corneliouzbett corneliouzbett merged commit a538012 into master May 20, 2024
3 checks passed
@corneliouzbett corneliouzbett deleted the OZ-497 branch May 20, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants